You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/02 04:56:53 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #6598: UI: Fix delete ISO navigation after job is finished
nvazquez opened a new pull request, #6598:
URL: https://github.com/apache/cloudstack/pull/6598
### Description
This PR fixes the navigation for ISOs after deletion. The following issues are addressed:
- After removal of an ISO without bulk operation -> The view keeps displaying the data of the removed ISO
- After removal of an ISO selecting bulk operation -> The view redirects to the 404 exception view
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
The following scenarios were tested on a single zone:
- Delete ISO without selecting any zone -> After removal, the ISO view is displayed
- Delete ISO selecting the zone and clicking on 'Bulk operation' -> After removal, the ISO view is displayed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203412118
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6598 (SL-JID-2061)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202020636
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6598 (SL-JID-2050)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202460354
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203408843
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202225145
@rohityadavcloud yes, instead of pushing new route maybe we can replace or rather use something like `$router.go(-2)` when `$router.go(-1)` isn't resolvable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202017798
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202461189
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202047595
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6598)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202610614
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6598)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203408293
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203786971
@shwstppr is this ready for merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202473167
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6598 (SL-JID-2053)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203442399
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6598)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6598&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6598&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6598&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202017690
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202210525
so we should remove from the history @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202401005
@shwstppr @utchoang do you know how to deal with 404 error when closing the bulk operation dialog? This 404 error is shown while the delete operation is in progress, after the delete finishes then it redirects correctly to the ISOs view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202387049
We discussed offline with @nvazquez for a few scenarios in which the 404 page shows again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1203408883
Thanks @shwstppr @slavkap, I think the issue is solved after applying @shwstppr's fix and a minor tweak to it, can you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6598: UI: Fix delete ISO navigation after job is finished
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6598:
URL: https://github.com/apache/cloudstack/pull/6598#issuecomment-1202437575
I think the 404 error can be prevented by checking the result of navigation while moving back from a view. With following changes I was able to see the difference
```
diff --git a/ui/src/views/image/IsoZones.vue b/ui/src/views/image/IsoZones.vue
index 7ca07ebb4b..74f4e39add 100644
--- a/ui/src/views/image/IsoZones.vue
+++ b/ui/src/views/image/IsoZones.vue
@@ -340,6 +340,13 @@ export default {
this.selectedRowKeys = []
this.fetchData()
if (this.dataSource.length === 0) {
+ this.moveToPreviousView()
+ }
+ },
+ async moveToPreviousView () {
+ const lastPath = this.$router.currentRoute.value.fullPath
+ const navigationResult = await this.$router.go(-1)
+ if (navigationResult !== undefined || this.$router.currentRoute.value.fullPath === lastPath) {
this.$router.go(-1)
}
},
@@ -379,7 +386,7 @@ export default {
successMethod: result => {
if (singleZone) {
if (this.selectedItems.length === 0) {
- this.$router.go(-1)
+ this.moveToPreviousView()
}
} else {
if (this.selectedItems.length === 0) {
@@ -388,6 +395,9 @@ export default {
}
if (this.selectedItems.length > 0) {
eventBus.emit('update-resource-state', { selectedItems: this.selectedItems, resource: record.zoneid, state: 'success' })
+ if (this.selectedItems.length === this.zones.length) {
+ this.moveToPreviousView()
+ }
}
},
errorMethod: () => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org