You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/09/07 20:32:25 UTC
[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395
MINIFICPP-602: Add ability to use CSV within url field
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-602
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #395
----
commit 79a3dda285466e6fb134abd11ca601ee204508b1
Author: Marc Parisi <ph...@...>
Date: 2018-09-07T20:29:07Z
MINIFICPP-602: Add ability to use CSV within url field
----
---
[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225666
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -88,12 +93,11 @@ class RemoteProcessorGroupPort : public core::Processor {
if (uuid != nullptr) {
uuid_copy(protocol_uuid_, uuid);
}
- site2site_port_ = -1;
+ //siteTosite_port_ = -1;
--- End diff --
should get removed
---
[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225824
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -201,10 +216,9 @@ class RemoteProcessorGroupPort : public core::Processor {
uuid_t protocol_uuid_;
// rest API end point info
- std::string host_;
- int port_;
- std::string protocol_;
- std::string url_;
+ std::vector<struct RPG> nifi_instances_;
+
+ //std::vector<std::string> urls_;
--- End diff --
should get removed
---
[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225710
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -137,16 +141,27 @@ class RemoteProcessorGroupPort : public core::Processor {
std::string getInterface() {
return local_network_interface_;
}
- // setURL
+ /**
+ * Sets the url. Supports a CSV
+ */
void setURL(std::string val) {
- url_ = val;
- utils::parse_url(&url_, &host_, &port_, &protocol_);
- if (port_ == -1) {
- if (protocol_.find("https") != std::string::npos) {
- port_ = 443;
- } else if (protocol_.find("http") != std::string::npos) {
- port_ = 80;
+ auto urls = utils::StringUtils::split(val, ",");
+ //url_ = val;
--- End diff --
should get removed
---
[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/395
---