You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/02/23 19:04:48 UTC
[GitHub] flink pull request: [FLINK-3454] Add test dependencies on packaged...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1698
[FLINK-3454] Add test dependencies on packaged jars
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3454_add_test_dependencies_on_packaged_jars
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1698
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3454] Add test dependencies on packaged...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1698#issuecomment-191806709
I think, this does not solve the problem of the test. The test case `ScalaShellITCase.testSubmissionOfExternalLibrary` expects that `flink-ml` has been packaged, because it looks in `../flink-libraries/flink-ml/target/` for the jar file. However, this is not guaranteed by introducing an dependency on `flink-ml` and `flink-dist`. Adding the dependency could also mean that it is simply downloaded from maven and stored in the local maven repository from where it is referenced.
What could help, though, is to find out the location of `flink-ml` and `flink-dist` from the provided classpath.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3454] Add test dependencies on packaged...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1698#issuecomment-195002236
@tillrohrmann That true, in cases the tests are run individually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3454] Add test dependencies on packaged...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1698#issuecomment-215472110
@tillrohrmann I count three issues:
1) this current PR guarantees that for a full parallel the jar will be built before the dependent test
2) when testing or verifying an individual module the jar file must be discovered in the classpath
3) running in an IDE there may be no jar file but instead a classes folder on the classpath, so we would need to package the folder in a jar file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #1698: [FLINK-3454] Add test dependencies on packaged jar...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/1698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---