[GitHub] eolivelli commented on a change in pull request #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #714: Issue-612 BOOKKEEPER-818: Make bookie recovery work with recovering multiple bookies
URL: https://github.com/apache/bookkeeper/pull/714#discussion_r150378234
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
 ##########
 @@ -442,6 +449,69 @@ public SyncObject() {
         }
     }
 
+    public SortedMap<Long, LedgerMetadata> getLedgersContainBookies(Set<BookieSocketAddress> bookies)
+            throws InterruptedException, BKException {
+        final SyncObject sync = new SyncObject();
 
 Review comment:
   I know this is kind of cherry pick.
   Can you consider dropping this and use CompletableFuture. This legacy way of coding can be affected by spurious wake ups

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services