You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/07 00:00:44 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11627: Fix thread local to be initialized on every thread.

robertwb commented on a change in pull request #11627:
URL: https://github.com/apache/beam/pull/11627#discussion_r421160293



##########
File path: sdks/python/apache_beam/utils/subprocess_server.py
##########
@@ -161,8 +161,9 @@ class JavaJarServer(SubprocessServer):
   BEAM_GROUP_ID = 'org.apache.beam'
   JAR_CACHE = os.path.expanduser("~/.apache_beam/cache/jars")
 
-  _BEAM_SERVICES = threading.local()
-  _BEAM_SERVICES.replacements = {}
+  _BEAM_SERVICES = _BEAM_SERVICES = type(

Review comment:
       Hmm... not sure how the duplicate got in there. 
   
   `type(...)` is actually creating a subclass here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org