You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/01/26 15:40:34 UTC
[GitHub] [lucene] mayya-sharipova opened a new pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
mayya-sharipova opened a new pull request #626:
URL: https://github.com/apache/lucene/pull/626
Before PR #608 this test when searching HnswGraph was using
numSeed (the search queue size) equal to 100.
This patch returns the original value of the search queue to 100,
and gets the top topK results from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #626:
URL: https://github.com/apache/lucene/pull/626#issuecomment-1022491591
Thanks, so exciting we have hierarchical graphs now! These little glitches are natural consequence of innovating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova merged pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #626:
URL: https://github.com/apache/lucene/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #626:
URL: https://github.com/apache/lucene/pull/626#issuecomment-1022332819
right, this restores the test condition. I see you also tightened the recall threshold from 0.8 to 0.9 -- did you run repeatedly to verify that won't sometimes fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova edited a comment on pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
Posted by GitBox <gi...@apache.org>.
mayya-sharipova edited a comment on pull request #626:
URL: https://github.com/apache/lucene/pull/626#issuecomment-1022468117
@msokolov Thank you for your feedback.
> I see you also tightened the recall threshold from 0.8 to 0.9 -- did you run repeatedly to verify that won't sometimes fail?
It was originally `0.9` (before PR #608), and yes I ran it many times to ensure the test would not fail this value of `0.9`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on pull request #626: LUCENE-10389 Adjust TestHnswGraph.testRandom
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on pull request #626:
URL: https://github.com/apache/lucene/pull/626#issuecomment-1022468117
@msokolov Thank you for your feedback.
> I see you also tightened the recall threshold from 0.8 to 0.9 -- did you run repeatedly to verify that won't sometimes fail?
It was originally `0.9` (before PR #608), and yes I ran it many times to ensure the test would not fail this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org