You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Tonnerre Lombard (JIRA)" <ji...@apache.org> on 2011/09/14 21:44:08 UTC

[jira] [Created] (THRIFT-1347) Unify the exceptions returned in generated Go code

Unify the exceptions returned in generated Go code
--------------------------------------------------

                 Key: THRIFT-1347
                 URL: https://issues.apache.org/jira/browse/THRIFT-1347
             Project: Thrift
          Issue Type: Improvement
          Components: Go - Compiler
    Affects Versions: 0.7
            Reporter: Tonnerre Lombard


The code generated by the Go compiler is quite awful; every type of exception that can be thrown creates an additional return value, so in the end any call looks like

ret, exA, exB, exC, exD, exE, exF, err = rpc.DoSomething(bla);

Since err is of type os.Error, which should cover all types of exceptions, the attached patch should make the interface significantly more sane by reducing the amount of different return values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1347) Unify the exceptions returned in generated Go code

Posted by "Tonnerre Lombard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tonnerre Lombard updated THRIFT-1347:
-------------------------------------

    Attachment: thrift-go-single-error-type.patch

Reduce all the different types of exceptions to one return value.

> Unify the exceptions returned in generated Go code
> --------------------------------------------------
>
>                 Key: THRIFT-1347
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1347
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.7
>            Reporter: Tonnerre Lombard
>         Attachments: thrift-go-single-error-type.patch
>
>
> The code generated by the Go compiler is quite awful; every type of exception that can be thrown creates an additional return value, so in the end any call looks like
> ret, exA, exB, exC, exD, exE, exF, err = rpc.DoSomething(bla);
> Since err is of type os.Error, which should cover all types of exceptions, the attached patch should make the interface significantly more sane by reducing the amount of different return values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1347) Unify the exceptions returned in generated Go code

Posted by "Tonnerre Lombard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tonnerre Lombard updated THRIFT-1347:
-------------------------------------

    Comment: was deleted

(was: Reduce all the different types of exceptions to one return value.)

> Unify the exceptions returned in generated Go code
> --------------------------------------------------
>
>                 Key: THRIFT-1347
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1347
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.7
>            Reporter: Tonnerre Lombard
>         Attachments: thrift-go-single-error-type.patch
>
>
> The code generated by the Go compiler is quite awful; every type of exception that can be thrown creates an additional return value, so in the end any call looks like
> ret, exA, exB, exC, exD, exE, exF, err = rpc.DoSomething(bla);
> Since err is of type os.Error, which should cover all types of exceptions, the attached patch should make the interface significantly more sane by reducing the amount of different return values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira