You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/31 03:38:59 UTC
[GitHub] [rocketmq] gorden5566 opened a new pull request #3204: [ISSUE 3203] Replace the class 'StringBuffer' by 'StringBuilder'
gorden5566 opened a new pull request #3204:
URL: https://github.com/apache/rocketmq/pull/3204
**Make sure set the target branch to `develop`**
## What is the purpose of the change
1. Replace the class 'StringBuffer' by 'StringBuilder'
2. Add missed '@override' annotation
3. Add braces to 'if' statement
4. Add test for `UtilAll#list2String`
#3203
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3204: [ISSUE 3203] Replace the class 'StringBuffer' by 'StringBuilder'
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3204:
URL: https://github.com/apache/rocketmq/pull/3204#issuecomment-890286113
[](https://coveralls.io/builds/41799713)
Coverage increased (+0.09%) to 54.201% when pulling **366ee98eb2c20c6ea1befa48ef416ac39ff9bff5 on gorden5566:optimize-string-concate** into **9e8fea9d5adf67cae4b8a2f041c6f6c2adc8813a on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3204: [ISSUE 3203] Replace the class 'StringBuffer' by 'StringBuilder'
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3204:
URL: https://github.com/apache/rocketmq/pull/3204#issuecomment-890286121
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3204](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (366ee98) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9e8fea9d5adf67cae4b8a2f041c6f6c2adc8813a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e8fea9) will **increase** coverage by `0.01%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #3204 +/- ##
=============================================
+ Coverage 48.45% 48.46% +0.01%
- Complexity 3185 3188 +3
=============================================
Files 418 418
Lines 26318 26318
Branches 3487 3487
=============================================
+ Hits 12752 12755 +3
+ Misses 11921 11914 -7
- Partials 1645 1649 +4
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/rocketmq/common/message/Message.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlLmphdmE=) | `54.21% <0.00%> (ø)` | |
| [...apache/rocketmq/common/protocol/NamespaceUtil.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvTmFtZXNwYWNlVXRpbC5qYXZh) | `54.83% <0.00%> (ø)` | |
| [...he/rocketmq/filter/expression/UnaryExpression.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvZXhwcmVzc2lvbi9VbmFyeUV4cHJlc3Npb24uamF2YQ==) | `21.05% <0.00%> (ø)` | |
| [...g/apache/rocketmq/filter/parser/TokenMgrError.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvcGFyc2VyL1Rva2VuTWdyRXJyb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/rocketmq/remoting/common/RemotingHelper.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9SZW1vdGluZ0hlbHBlci5qYXZh) | `13.41% <0.00%> (ø)` | |
| [...pache/rocketmq/store/stats/BrokerStatsManager.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3N0YXRzL0Jyb2tlclN0YXRzTWFuYWdlci5qYXZh) | `75.89% <50.00%> (ø)` | |
| [.../apache/rocketmq/filter/parser/ParseException.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvcGFyc2VyL1BhcnNlRXhjZXB0aW9uLmphdmE=) | `49.25% <66.66%> (ø)` | |
| [...cketmq/acl/plain/RemoteAddressStrategyFactory.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUmVtb3RlQWRkcmVzc1N0cmF0ZWd5RmFjdG9yeS5qYXZh) | `89.76% <100.00%> (ø)` | |
| [.../main/java/org/apache/rocketmq/common/UtilAll.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVXRpbEFsbC5qYXZh) | `40.25% <100.00%> (+2.59%)` | :arrow_up: |
| [...ache/rocketmq/store/AllocateMappedFileService.java](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FsbG9jYXRlTWFwcGVkRmlsZVNlcnZpY2UuamF2YQ==) | `39.02% <0.00%> (-2.44%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/rocketmq/pull/3204/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e8fea9...366ee98](https://codecov.io/gh/apache/rocketmq/pull/3204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou merged pull request #3204: [ISSUE 3203] Replace the class 'StringBuffer' by 'StringBuilder'
Posted by GitBox <gi...@apache.org>.
odbozhou merged pull request #3204:
URL: https://github.com/apache/rocketmq/pull/3204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org