You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/04 13:20:06 UTC

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #42: Some cibuild.sh improvements

xiaoxiang781216 commented on a change in pull request #42:
URL: https://github.com/apache/incubator-nuttx-testing/pull/42#discussion_r419429172



##########
File path: cibuild.sh
##########
@@ -289,6 +291,8 @@ function install_tools {
     $func
   done
   popd
+
+  echo PATH=$EXTRA_PATH\$PATH > $prebuilt/env.sh

Review comment:
       Who will use this?

##########
File path: cibuild.sh
##########
@@ -48,6 +48,14 @@ function python-tools {
   PYTHONUSERBASE=$prebuilt/pylocal
   export PYTHONUSERBASE
   add_path $PYTHONUSERBASE/bin
+  case $os in
+    Darwin)
+      PIP=pip3

Review comment:
       Should we always use pip3?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org