[jira] Commented: (PIG-443) Illustrate for the Types branch

["Pradeep Kamath (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633562#action_12633562 ] 

Pradeep Kamath commented on PIG-443:
------------------------------------

I haven't completely gone through the code - but initial comments:

- since PigServer.getExamples(alias) works on the optimized plan it may have some changes to original operators expected by the user script - for  example additional foreach for casting to schema types. moving of filters etc. (an explain before the illustrate would result in optimization of the plan, if there is no explain, then it may not be optimized)

- currently I am getting NullPointerException after applying the patch to a fresh svn checkout and running the following script:
a = load 'somefile';
illustrate a;

- Cosmetic: There are "tabs" instead of 4 spaces in some of the code 

- Has streaming been tested with illustrate?

- Apache header is missing from new files

- Class level comments for new classes would be helpful



> Illustrate for the Types branch
> -------------------------------
>
>                 Key: PIG-443
>                 URL: https://issues.apache.org/jira/browse/PIG-443
>             Project: Pig
>          Issue Type: New Feature
>    Affects Versions: types_branch
>            Reporter: Shubham Chopra
>            Assignee: Shubham Chopra
>             Fix For: types_branch
>
>         Attachments: pig_types_22_09.patch
>
>
> This implementation of Illustrate uses visitors to traverse the plans.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.