[GitHub] utzig commented on a change in pull request #1439: test/runtest: Null-terminate segments of log entry

[GitBox <gi...@apache.org>]

utzig commented on a change in pull request #1439: test/runtest: Null-terminate segments of log entry
URL: https://github.com/apache/mynewt-core/pull/1439#discussion_r222277771
 
 

 ##########
 File path: compiler/arm-none-eabi-m4/compiler.yml
 ##########
 @@ -26,9 +26,9 @@ compiler.path.objsize: arm-none-eabi-size
 compiler.path.objcopy: arm-none-eabi-objcopy
 
 compiler.flags.base: -mcpu=cortex-m4 -mthumb-interwork -mthumb -Wall -Werror -fno-exceptions -ffunction-sections -fdata-sections
-compiler.flags.default: [compiler.flags.base, -O1 -ggdb]
-compiler.flags.optimized: [compiler.flags.base, -Os -ggdb]
-compiler.flags.debug: [compiler.flags.base, -Og -ggdb]
+compiler.flags.default: [compiler.flags.base, -O1, -ggdb]
+compiler.flags.optimized: [compiler.flags.base, -Os, -ggdb]
+compiler.flags.debug: [compiler.flags.base, -Og, -ggdb]
 
 Review comment:
   Why must this be done? And why not do the same for m0/m3/m7/riscv?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services