[GitHub] [spark] LuciferYang commented on a diff in pull request #41264: [SPARK-43717][CONNECT] Scala client reduce agg cannot handle null partitions for scala primitive inputs

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41264:
URL: https://github.com/apache/spark/pull/41264#discussion_r1205649033


##########
sql/core/src/main/scala/org/apache/spark/sql/expressions/ReduceAggregator.scala:
##########
@@ -32,7 +32,10 @@ private[sql] class ReduceAggregator[T: Encoder](func: (T, T) => T)
 
   @transient private val encoder = implicitly[Encoder[T]]
 
-  override def zero: (Boolean, T) = (false, null.asInstanceOf[T])

Review Comment:
   hmm... Is this question for `Dataset#reduce` or `ReduceAggregator`?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org