You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/07 07:33:43 UTC

[GitHub] [arrow] waynexia commented on pull request #8856: ARROW-10355: [Rust] Add support for list_sort

waynexia commented on pull request #8856:
URL: https://github.com/apache/arrow/pull/8856#issuecomment-739730551


   Thanks for your reply @jorgecarleitao. Sorry for the incorrect understand I've made. 
   
   So the required `list_sort` is not part of `Sort( ArrayRef )` in `sort.rs` which will rearrange the given array. But a method of `ListArray` that performs `Sort` on each underlying sub-array, right?
   
   And then where do you think is a proper place to put `list_sort`, a separate file under `compute/kernel` or as a member function of `ListArray`, or someplace else. Please let me know what do you think :raised_hands:
   
   BTW, is the current implementation that rearranges the input array needed to be part of `Sort`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org