You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lo...@apache.org on 2020/12/16 01:45:54 UTC

[beam] branch lostluck-porta created (now f556a77)

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a change to branch lostluck-porta
in repository https://gitbox.apache.org/repos/asf/beam.git.


      at f556a77  Use portable job submission by default for Go.

This branch includes the following new commits:

     new f556a77  Use portable job submission by default for Go.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[beam] 01/01: Use portable job submission by default for Go.

Posted by lo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch lostluck-porta
in repository https://gitbox.apache.org/repos/asf/beam.git

commit f556a77f603b9e0aeacdfec99a8d852643a06337
Author: Robert Burke <lo...@users.noreply.github.com>
AuthorDate: Tue Dec 15 17:45:22 2020 -0800

    Use portable job submission by default for Go.
---
 sdks/go/pkg/beam/runners/dataflow/dataflow.go | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/sdks/go/pkg/beam/runners/dataflow/dataflow.go b/sdks/go/pkg/beam/runners/dataflow/dataflow.go
index 3ff23da..6352cd9 100644
--- a/sdks/go/pkg/beam/runners/dataflow/dataflow.go
+++ b/sdks/go/pkg/beam/runners/dataflow/dataflow.go
@@ -129,16 +129,23 @@ func Execute(ctx context.Context, p *beam.Pipeline) (beam.PipelineResult, error)
 
 	experiments := jobopts.GetExperiments()
 	// Always use runner v2, unless set already.
-	var v2set bool
+	var v2set, portaSubmission bool
 	for _, e := range experiments {
 		if strings.Contains(e, "use_runner_v2") || strings.Contains(e, "use_unified_worker") {
 			v2set = true
-			break
+		}
+		if strings.Contains(e, "use_portable_job_submission") {
+			portaSubmission = true
 		}
 	}
+	// Enable Default unified worker, and portable job submission.
 	if !v2set {
 		experiments = append(experiments, "use_unified_worker")
 	}
+	if !portaSubmission {
+		experiments = append(experiments, "use_portable_job_submission")
+	}
+	
 	if *minCPUPlatform != "" {
 		experiments = append(experiments, fmt.Sprintf("min_cpu_platform=%v", *minCPUPlatform))
 	}