[jira] [Commented] (HBASE-18731) [compat 1-2] QuotaSettings#setupSetQuotaRequest param changed

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157740#comment-16157740 ] 

Sean Busbey commented on HBASE-18731:
-------------------------------------

presumably this can also cover

{code}public static SetQuotaRequest buildSetQuotaRequestProto(final QuotaSettings settings){code} in QuotaSettings? Or is there a different jira for that already?

QuotaSettings is an Admin API and this is an instance of protobufs in our public API. Better maybe to just release not it and make sure only a POJO is within the public API for 2.0?

> [compat 1-2] QuotaSettings#setupSetQuotaRequest param changed
> -------------------------------------------------------------
>
>                 Key: HBASE-18731
>                 URL: https://issues.apache.org/jira/browse/HBASE-18731
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>            Assignee: Sean Busbey
>             Fix For: 2.0.0-alpha-3
>
>
> QuotaSettings is Audience public. The param for setupSetQuotaRequest moved to package org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.SetQuotaRequest. QuotaSettings was added in 1.1.
> Is QuotaSettings for use by anyone but our CPEP?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)