You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (Jira)" <ji...@apache.org> on 2020/04/22 13:54:00 UTC
[jira] [Commented] (FLINK-14499)
MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull
[ https://issues.apache.org/jira/browse/FLINK-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089692#comment-17089692 ]
Till Rohrmann commented on FLINK-14499:
---------------------------------------
I think it is not true that {{MetricRegistry#getMetricQueryServiceGatewayRpcAddress}} is always non-null. Take a look at {{NoOpMetricRegistry}}. Please refrain from these kind of changes unless you are sure that your assumptions hold.
> MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull
> ----------------------------------------------------------------
>
> Key: FLINK-14499
> URL: https://issues.apache.org/jira/browse/FLINK-14499
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: Zili Chen
> Assignee: AT-Fieldless
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As codebase moved, I suspect {{MetricRegistry#getMetricQueryServiceGatewayRpcAddress}} is now non-null. One can try to figure it out and if so, refactor related code a bit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)