You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/26 02:25:38 UTC

[GitHub] [servicecomb-service-center] lilai23 opened a new pull request #792: implement of mongo DumpCache interface and optimization of syncer

lilai23 opened a new pull request #792:
URL: https://github.com/apache/servicecomb-service-center/pull/792


   dumpcache接口实现以及syncer代码优化
   
       1.实现mongo的dumpcache接口
       2.syncer逻辑优化
       3.existence接口请求bug修复
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [servicecomb-service-center] lilai23 closed pull request #792: implement of mongo DumpCache interface and optimization of syncer

Posted by GitBox <gi...@apache.org>.
lilai23 closed pull request #792:
URL: https://github.com/apache/servicecomb-service-center/pull/792


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [servicecomb-service-center] lilai23 commented on a change in pull request #792: implement of mongo DumpCache interface and optimization of syncer

Posted by GitBox <gi...@apache.org>.
lilai23 commented on a change in pull request #792:
URL: https://github.com/apache/servicecomb-service-center/pull/792#discussion_r548933796



##########
File path: client/microservice.go
##########
@@ -94,7 +94,7 @@ func (c *Client) ServiceExistence(ctx context.Context, domain, project string, a
 	query := url.Values{}
 	query.Set("type", "microservice")
 	query.Set("env", env)
-	query.Set("appID", appID)

Review comment:
       
   ![image](https://user-images.githubusercontent.com/46025350/103144497-2d2b1800-4765-11eb-9a41-3464352c1c79.png)
   
   ![image](https://user-images.githubusercontent.com/46025350/103144506-551a7b80-4765-11eb-9a80-11f498ada794.png)
   
   exsitence接口 appId在set和get时不一致
   
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org