You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/05/18 18:50:51 UTC
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/577
TAJO-1599: Implement NodeResourceManager and Status updater
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1599
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #577
----
commit 0d6ca33ec2d5b6f5be8bd3d78385b620548a7efb
Author: Jinho Kim <jh...@apache.org>
Date: 2015-05-15T03:03:59Z
TAJO-1599
commit 211f000bb8c14af81b5d77be9ae355b6d0b56cb1
Author: Jinho Kim <jh...@apache.org>
Date: 2015-05-18T07:15:14Z
TAJO-1599
commit 9631601b875f01e72fa4a3e74ec7c2a157d8a34f
Author: Jinho Kim <jh...@apache.org>
Date: 2015-05-18T07:15:30Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1599
commit c0257fdc33009f26e31cbd8a1043f3bd6f7600ce
Author: Jinho Kim <jh...@apache.org>
Date: 2015-05-18T16:42:49Z
add test cases
commit fafd6487a56980355b3b596d392f299aad2d434f
Author: Jinho Kim <jh...@apache.org>
Date: 2015-05-18T16:43:54Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1599
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/577#issuecomment-105546419
I was add the new key of disk configuration because if I change the configuration, it affects the current resource.
When I remove the legacy configuration, I will update the document.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/577#issuecomment-105342169
Hi @jinossy, it's really nice work.
I've almost read your patch. I'll finish my review soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/577#issuecomment-105347498
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/577#issuecomment-105503486
This patch requires updating documentation because it affects the resource configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/577#issuecomment-105395728
Thank you for the review!
I'll commit soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1599: Implement NodeResourceManager and St...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy closed the pull request at:
https://github.com/apache/tajo/pull/577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---