You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/28 14:53:50 UTC

[GitHub] [rocketmq-client-go] yuanmoon commented on issue #762: [Consumer]The exception handling of function doUnlock needs to be optimized

yuanmoon commented on issue #762:
URL: https://github.com/apache/rocketmq-client-go/issues/762#issuecomment-1002142776


   > Hi @yuanmoon, `OneWay` means the caller doesn't care about the execution result, if one wants to know something response content, he/she should not use `oneway`.
   
   @wenfengwang 
   I don't understand what you mean very much. Maybe I don't express it clearly enough. The key point I want to optimize is that when `oneway` is false, no matter `err` is null or not, there is always error message output by `rlog.Error`. I think this is unreasonable and it's better that error message is output when `err` isn't null or `response.Code` isn't success.
   So I make some change based on the above. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org