You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by gh...@apache.org on 2017/05/05 10:15:19 UTC
svn commit: r1794000 -
/sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java
Author: ghenzler
Date: Fri May 5 10:15:19 2017
New Revision: 1794000
URL: http://svn.apache.org/viewvc?rev=1794000&view=rev
Log:
SLING-6806 improved table layout to save space
Modified:
sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java
Modified: sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java?rev=1794000&r1=1793999&r2=1794000&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/core/src/main/java/org/apache/sling/hc/core/impl/servlet/ResultHtmlSerializer.java Fri May 5 10:15:19 2017
@@ -81,22 +81,19 @@ public class ResultHtmlSerializer {
final DateFormat dfLong = new SimpleDateFormat("yyyy-MM-dd HH:mm");
writer.println("<table id=\"healthCheckResults\" cellspacing=\"0\">");
- writer.println("<thead><tr><th>Health Check</th><th>Status</th><th>Log</th><th>Finished At</th><th>Execution Time</th></tr></thead>");
+ writer.println(
+ "<thead><tr><th>Health Check <span style='color:gray'>(tags)</span></th><th>Status</th><th>Log</th><th>Finished At</th><th>Time</th></tr></thead>");
for (HealthCheckExecutionResult executionResult : executionResults) {
Result result = executionResult.getHealthCheckResult();
List<String> tags = executionResult.getHealthCheckMetadata().getTags();
boolean hasTags = tags != null && tags.size() > 0 && StringUtils.isNotBlank(tags.get(0));
- writer.print("<tr class=\"" + getClassForStatus(result.getStatus()) + "\" ");
- if (hasTags) {
- writer.print("title=\"Tags: " + StringEscapeUtils.escapeHtml(StringUtils.join(tags, ",")) + "\"");
- }
- writer.println(">");
+ writer.print("<tr class=\"" + getClassForStatus(result.getStatus()) + "\">");
writer.print("<td><p title=\"" + StringEscapeUtils.escapeHtml(executionResult.getHealthCheckMetadata().getName()) + "\">"
- + StringEscapeUtils.escapeHtml(executionResult.getHealthCheckMetadata().getTitle()) + "</p>");
+ + StringEscapeUtils.escapeHtml(executionResult.getHealthCheckMetadata().getTitle()) + "");
if (hasTags) {
- writer.println("<span>Tags: " + StringEscapeUtils.escapeHtml(StringUtils.join(tags, ", ")) + "</span>");
+ writer.println("<br/><span style='color:gray'>" + StringEscapeUtils.escapeHtml(StringUtils.join(tags, ", ")) + "</span>");
}
- writer.println("</td>");
+ writer.println("</p></td>");
writer.println("<td style='font-weight:bold;'>" + StringEscapeUtils.escapeHtml(result.getStatus().toString()) + "</td>");
writer.println("<td>");
boolean isFirst = true;