You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "rhoughton-pivot (GitHub)" <gi...@apache.org> on 2019/11/01 19:46:10 UTC

[GitHub] [geode] rhoughton-pivot commented on issue #4262: GEODE-7383: geode-ci concourse resource doesn't care about all of ci

We also keep it as a separate resource in the PR pipeline so that we don't
run random unmerged scripts in our CI infrastructure.

On Fri, Nov 1, 2019, 09:37 Owen Nichols <no...@github.com> wrote:

> *@onichols-pivotal* commented on this pull request.
>
> This change seems fine. However, I wonder if we could go a step further
> and eliminate having geode-ci as a separate resource entirely. The
> historical reason for having it separate, was to allow latest scripts in ci
> to be used independently of the geode SHA. However, more in the last year
> it has been changed to have the same passing constraints as the geode
> resource, so it is effectively identical. We could just search and replace
> geode-ci/ci to geode/ci and get rid of this resource entirely.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/4262?email_source=notifications&email_token=AHVPPUVQJKSQINMH2Z63A33QRRLOHA5CNFSM4JHQOTM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKBNBFQ#pullrequestreview-310562966>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHVPPUVHSJUKF4WDDCM22HLQRRLOHANCNFSM4JHQOTMQ>
> .
>


[ Full content available at: https://github.com/apache/geode/pull/4262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org