You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:22:55 UTC

[GitHub] [bookkeeper] lhotari opened a new pull request #2460: Limit maven http connection pool TTL in Github flows

lhotari opened a new pull request #2460:
URL: https://github.com/apache/bookkeeper/pull/2460


   ### Motivation
   
   Fixes "Tranfer failed for https://repo.maven.apache.org/...
   .jar: Connection reset" type of failures in Github Flows environment
   
   ### Changes
   
   Set `maven.wagon.httpconnectionManager.ttlSeconds` to 25 seconds.
   Besides this, set `maven.wagon.http.retryHandler.count` to 3 retries.
   
   https://issues.apache.org/jira/browse/WAGON-545
   contains a recommendation "Azure users shall set the TTL to 240 seconds or less."
   
   The reason for the 25 second TTL is to ensure that it's shorter than any common
   firewall or NAT timeout. Some NATs have a 30 second idle timeout although
   that is very rare. There shouldn't be harm in using the 25 second TTL since
   the connection pool will be able to pool connections well with a 25 second TTL.
   
   The documentation for `maven.wagon.httpconnectionManager.ttlSeconds` is
   available in the source code:
   https://github.com/apache/maven-wagon/blob/wagon-3.4.1/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L297-L305
   
   Documentation for `maven.wagon.http.retryHandler.count` is in
   https://maven.apache.org/wagon/wagon-providers/wagon-http/
   "Any retry handler can only react to exceptions when executing the request and
   receiving the response head. It will not salvage in-flight failures of ongoing
   response body streams." Therefore the retry count setting is a bit
   different than expected. WAGON-545 explains that ConnectionExceptions
   aren't part of the retried exceptions by default. If such issues become
   problems, it's possible to configure the retry handler in a more fine
   grained way.
   
   This is similar to the change made in Pulsar: https://github.com/apache/pulsar/pull/8386


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] Ghatage commented on pull request #2460: Limit maven http connection pool TTL in Github flows

Posted by GitBox <gi...@apache.org>.
Ghatage commented on pull request #2460:
URL: https://github.com/apache/bookkeeper/pull/2460#issuecomment-717358936


   Awesome, thanks and welcome @lhotari !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] jiazhai merged pull request #2460: Limit maven http connection pool TTL in Github flows

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #2460:
URL: https://github.com/apache/bookkeeper/pull/2460


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lhotari commented on pull request #2460: Limit maven http connection pool TTL in Github flows

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #2460:
URL: https://github.com/apache/bookkeeper/pull/2460#issuecomment-717366796


   @eolivelli  @Ghatage Thank you. I'm happy to join the BK community. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org