[jira] [Commented] (NIFI-4217) CaptureChangeMySQL DDL lowercases table names

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098557#comment-16098557 ] 

ASF GitHub Bot commented on NIFI-4217:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2036

    NIFI-4217: Retain original DDL in CaptureChangeMySQL

    The DDL contents were being "normalized" to check for certain keywords like "alter table". However this normalized version was being passed on, instead of the original DDL.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4217

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2036
    
----
commit 85eb45c8b4756e11db0756256810812842617ef3
Author: Matt Burgess <ma...@apache.org>
Date:   2017-07-24T15:14:03Z

    NIFI-4217: Retain original DDL in CaptureChangeMySQL

----


> CaptureChangeMySQL DDL lowercases table names
> ---------------------------------------------
>
>                 Key: NIFI-4217
>                 URL: https://issues.apache.org/jira/browse/NIFI-4217
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> 1. Create a flow to read a database say "db"
> 2. Start the flow
> 3. Create a table "ChangeMysqlCapture" 
> 4. Check the contents of the ChangeMysqlCapture output FF
> Result : The query is completely in lower case
> Example : 
> {code:javascript}
> CREATE TABLE ChangeDataCapture_suaqvkrnlw
> ( uuid int NOT NULL AUTO_INCREMENT PRIMARY KEY,
>   varcharc VARCHAR(255),
>   charc char(50)
> );
> {code}
> Contents of the Flow file
> {code:js}
> {"type":"ddl","timestamp":1500536076000,"binlog_filename":"mysql-bin.000001","binlog_position":351,"database":"nifiqe","table_name":null,"table_id":null,"query":"create table changedatacapture_pvkweznqmo\n( uuid int not null auto_increment primary key,\n varcharc varchar(255),\n charc char(50)\n)"}
> {code}
> The entire query is in lower case as can be found here
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L804



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)