[GitHub] [incubator-yunikorn-core] pbacsko edited a comment on pull request #385: [YUNIKORN-998] expose gang related info in application REST info

[GitBox <gi...@apache.org>]

pbacsko edited a comment on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#issuecomment-1074984960


   > @pbacsko could this be an issue with the changes from YUNIKORN-638:
   > 
   > > ```
   > > 2022-03-21T14:29:51.304Z	ERROR	cache/placeholder_manager.go:88	failed to create placeholder pod	{"error": "Pod \"tg-spark-driver12324538-spark-a8949f51c61541909b1428-0\" is invalid: spec.containers[0].image: Required value"}
   > > github.com/apache/incubator-yunikorn-k8shim/pkg/cache.(*PlaceholderManager).createAppPlaceholders
   > > 	/home/ted/Desktop/younikon/998/incubator-yunikorn-k8shim/pkg/cache/placeholder_manager.go:88
   > > ```
   
   Yeah, but I'm not sure how. Is it coming from a running YK instance? Or an e2e test, unit test?
   
   It's interesting because when we parse the flags, we use default values in the code, which is the usual "k8s.gcr.io/pause". Perhaps somehow an empty value was passed to the cmd line switch, like `--placeholderImage=` and `$PLACEHOLDER_IMAGE}` is undefined. That can possibly happen if YK was not deployed with helm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org