You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/08/14 17:46:13 UTC

[GitHub] spark pull request #22101: [SPARK-25114][Core] Fix RecordBinaryComparator wh...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22101#discussion_r210043412
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java ---
    @@ -27,7 +27,6 @@
       public int compare(
    --- End diff --
    
    Let us add a test suite for this function as you mentioned in the line 25. : )


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org