You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Joe Orton <jo...@redhat.com> on 2012/10/01 14:28:26 UTC

Re: t/api/server_const.t test failure from Red Hat developer vanity patches

On Wed, Aug 01, 2012 at 01:41:34PM -0700, Fred Moyer wrote:
> The reason this test failure occurs is because the RedHat rpm devs
> patched the version component code to replace 'Unix' with @VENDOR@, in
> these cases either Centos or Fedora. But their patch isn't complete -
> they didn't patch the server description code, so that returns 'Unix'
> instead of 'Centos'.

Sorry about that Fred, that's my mistake.  I've fixed this for future 
releases by changing the #define PLATFORM in os.h to use the vendor 
name.

(FWIW, we patch Server not only for our own vanity: customers request 
differentiation of the Server header for internal audit purposes.)

Regards, Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/api/server_const.t test failure from Red Hat developer vanity patches

Posted by Fred Moyer <fr...@redhotpenguin.com>.
On Oct 1, 2012 5:28 AM, "Joe Orton" <jo...@redhat.com> wrote:
>
> On Wed, Aug 01, 2012 at 01:41:34PM -0700, Fred Moyer wrote:
> > The reason this test failure occurs is because the RedHat rpm devs
> > patched the version component code to replace 'Unix' with @VENDOR@, in
> > these cases either Centos or Fedora. But their patch isn't complete -
> > they didn't patch the server description code, so that returns 'Unix'
> > instead of 'Centos'.
>
> Sorry about that Fred, that's my mistake.  I've fixed this for future
> releases by changing the #define PLATFORM in os.h to use the vendor
> name.

No problem, thanks for the fix!

>
> (FWIW, we patch Server not only for our own vanity: customers request
> differentiation of the Server header for internal audit purposes.)
>
> Regards, Joe