You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/04 23:02:18 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11936: chore: consolidate common code in importers
codecov-io edited a comment on pull request #11936:
URL: https://github.com/apache/incubator-superset/pull/11936#issuecomment-739066965
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=h1) Report
> Merging [#11936](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=desc) (010fa41) into [PISQL-31](https://codecov.io/gh/apache/incubator-superset/commit/fc347505172146ce458b5b8e4b4796cd9257ac02?el=desc) (fc34750) will **decrease** coverage by `4.52%`.
> The diff coverage is `96.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## PISQL-31 #11936 +/- ##
============================================
- Coverage 67.46% 62.94% -4.53%
============================================
Files 920 918 -2
Lines 44819 44544 -275
Branches 4246 4247 +1
============================================
- Hits 30235 28036 -2199
- Misses 14481 16329 +1848
- Partials 103 179 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <93.33%> (+0.01%)` | :arrow_up: |
| python | `63.00% <97.01%> (-1.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0LnB5) | `96.96% <66.66%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <91.66%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.31% <95.31%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <100.00%> (-10.66%)` | :arrow_down: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `69.15% <100.00%> (-4.68%)` | :arrow_down: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `73.73% <100.00%> (-10.11%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `55.33% <100.00%> (-16.67%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `67.30% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.28% <100.00%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+6.74%)` | :arrow_up: |
| ... and [214 more](https://codecov.io/gh/apache/incubator-superset/pull/11936/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=footer). Last update [fc34750...69a7ac7](https://codecov.io/gh/apache/incubator-superset/pull/11936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org