You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexander Kleymenov (JIRA)" <ji...@apache.org> on 2006/06/07 13:47:29 UTC
[jira] Created: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
[classlib] HttpURLConnection does not use proxy
-----------------------------------------------
Key: HARMONY-570
URL: http://issues.apache.org/jira/browse/HARMONY-570
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Alexander Kleymenov
Priority: Minor
Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does not use proxy
Posted by Andrew Zhang <zh...@gmail.com>.
Hi, Mikhail,
The test is not unstable.
Current Harmony acts the same as RI, and I have tested them on serveral
machines with both windows and linux.
However, I agree that the behaviour is not logical. It seems a bug of RI.
I also agree to apply this patch for fixing the problem. Many thanks!
On 6/8/06, Mikhail Loenko (JIRA) <ji...@apache.org> wrote:
>
> [
> http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12415276]
>
> Mikhail Loenko commented on HARMONY-570:
> ----------------------------------------
>
> I've tried it on BEA 1.5.0_b64, test passed.
> Probably the test is unstable for the reason described in HARMONY-530.
>
> I'll fix it in a similar way
>
>
> > [classlib] HttpURLConnection does not use proxy
> > -----------------------------------------------
> >
> > Key: HARMONY-570
> > URL: http://issues.apache.org/jira/browse/HARMONY-570
> > Project: Harmony
> > Type: Bug
>
> > Components: Classlib
> > Reporter: Alexander Kleymenov
> > Assignee: Mikhail Loenko
> > Priority: Minor
> > Attachments: bugtest.java, patch.txt
> >
> > Current HttpURLConnection implementation does not use proxy specified in
> openConnection method.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
--
Andrew Zhang
China Software Development Lab, IBM
[jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12415951 ]
Mikhail Loenko commented on HARMONY-570:
----------------------------------------
Hi Alex, some tests fail if apply new patch, could you please look at them?
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
Posted by "Alexander Kleymenov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Alexander Kleymenov updated HARMONY-570:
----------------------------------------
Attachment: new_patch.txt
Hi Andrew,
The reason RI finished with the same result is setting up the System Properties.
Try to run the test with commented lines setting pkgs property.
Or make sure that you have no
org.apache.harmony.luni.internal.net.www.protocol
package in class path.
I figured out that my fix causes the problem with default ProxySelector installed in the system.
New patch fixes this problem. It contains all the changes made before and implements regression tests.
Thank You,
Alexander
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12415126 ]
Andrew Zhang commented on HARMONY-570:
--------------------------------------
Hi, Alexander,
I ran your test against RI and Harmony. The output is the same:
Connection uses proxy: false
FAILED: Proxy server was not used
Would you please give some comments on the test case? Thanks.
My Environment:
RI:
java version "1.5.0"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
Java HotSpot(TM) Client VM (build 1.5.0-b64, mixed mode)
OS:
Windows XP SP2
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Priority: Minor
> Attachments: bugtest.java, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Mikhail Loenko resolved HARMONY-570:
------------------------------------
Resolution: Fixed
finally, fixed in revision 413846
Alexander, please check it was done as expected
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt, patch_new_02.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Mikhail Loenko reassigned HARMONY-570:
--------------------------------------
Assign To: Mikhail Loenko
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12415276 ]
Mikhail Loenko commented on HARMONY-570:
----------------------------------------
I've tried it on BEA 1.5.0_b64, test passed.
Probably the test is unstable for the reason described in HARMONY-530.
I'll fix it in a similar way
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Alexander Kleymenov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12416119 ]
Alexander Kleymenov commented on HARMONY-570:
---------------------------------------------
Looks fine! Thank You!
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt, patch_new_02.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
Posted by "Alexander Kleymenov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Alexander Kleymenov updated HARMONY-570:
----------------------------------------
Attachment: bugtest.java
To reproduce the problem run the attached test. On the current implementation its output is:
Connection uses proxy: false
FAILED: Proxy server was not used
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Priority: Minor
> Attachments: bugtest.java, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-570) [classlib] HttpURLConnection does
not use proxy
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=comments#action_12415519 ]
Andrew Zhang commented on HARMONY-570:
--------------------------------------
Hi Alexander,
Thanks for the information.
I agree that it's a bug of Haromny. Please fix it. Thanks.
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
Posted by "Alexander Kleymenov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Alexander Kleymenov updated HARMONY-570:
----------------------------------------
Attachment: patch_new_02.txt
Thank You for noting this. Default port was unused.
This problem is fixed with attached patch. It aggregates all of the previous fixes.
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt, patch_new_02.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Mikhail Loenko closed HARMONY-570:
----------------------------------
verified by Alexander
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Assignee: Mikhail Loenko
> Priority: Minor
> Attachments: bugtest.java, new_patch.txt, patch.txt, patch_new_02.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-570) [classlib] HttpURLConnection does not
use proxy
Posted by "Alexander Kleymenov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-570?page=all ]
Alexander Kleymenov updated HARMONY-570:
----------------------------------------
Attachment: patch.txt
Attached patch fixes this problem.
> [classlib] HttpURLConnection does not use proxy
> -----------------------------------------------
>
> Key: HARMONY-570
> URL: http://issues.apache.org/jira/browse/HARMONY-570
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Alexander Kleymenov
> Priority: Minor
> Attachments: bugtest.java, patch.txt
>
> Current HttpURLConnection implementation does not use proxy specified in openConnection method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira