You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "alaendle (via GitHub)" <gi...@apache.org> on 2025/04/03 07:07:08 UTC

[PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

alaendle opened a new pull request, #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93

   Simple change - but enabled really a bandwidth of possibilities (e.g. use RabbitMQ vhosts).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "alaendle (via GitHub)" <gi...@apache.org>.
alaendle commented on code in PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#discussion_r2032606021


##########
src/NMS.AMQP/NmsConnectionFactory.cs:
##########
@@ -367,6 +375,9 @@ private void SetUriOptions(StringDictionary options)
         {
             StringDictionary nmsOptions = PropertyUtil.FilterProperties(options, "nms.");
             PropertyUtil.SetProperties(this, nmsOptions);
+
+            StringDictionary amqpOptions = PropertyUtil.FilterProperties(options, "amqp.");

Review Comment:
   Sorry - don't know why I've missed that at the first place. Thanks for the hint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "alaendle (via GitHub)" <gi...@apache.org>.
alaendle commented on PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#issuecomment-2774701987

   @Havret - Since this repository hasn't seen many changes and you were one of the last committers, is there a real chance that this change will be committed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret commented on code in PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#discussion_r2032070943


##########
test/Apache-NMS-AMQP-Test/ConnectionFactoryTest.cs:
##########


Review Comment:
   Please add similar test to AmqpProviderFactoryTest instead.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret commented on PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#issuecomment-2774778392

   Hey @alaendle, yes it is. I will take a look later this week. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "alaendle (via GitHub)" <gi...@apache.org>.
alaendle commented on PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#issuecomment-2826443231

   @Havret Thanks again for your guidance, it was a pleasure to bring this over the line. Any chance to get a new release for NuGet? (one way more important argument for this - I mean more important than this change - the latest release version of Apache.NMS.AMQP isn't compatible with the latest Apache.NMS release (https://www.nuget.org/packages/Apache.NMS/2.1.0) - so this could be resolved as well). Anything I could do to make this happen?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "alaendle (via GitHub)" <gi...@apache.org>.
alaendle commented on PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#issuecomment-2782832376

   @Havret, thanks for your valuable feedback. I tried to integrate it fully. I wasn't sure whether to add the complexity of an `IAmqpContext` - similar to `ITransportContext` - or keep the code as simple and unmodified as possible. So, for now, I've chosen the easy route. Please let me know what additional changes you would like to see to get this over the line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret commented on code in PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#discussion_r2032068610


##########
src/NMS.AMQP/NmsConnectionFactory.cs:
##########
@@ -367,6 +375,9 @@ private void SetUriOptions(StringDictionary options)
         {
             StringDictionary nmsOptions = PropertyUtil.FilterProperties(options, "nms.");
             PropertyUtil.SetProperties(this, nmsOptions);
+
+            StringDictionary amqpOptions = PropertyUtil.FilterProperties(options, "amqp.");

Review Comment:
   This is actually already implemented in `AmqpProviderFactory`. The only change needed is to add an additional property to the `AmqpProvider` class. That should allow the `vhost` property to be propagated appropriately.
   
   It shouldn't be configured at the connection level—it belongs on the AMQP provider  (at least that's how it's handled in Qpid).
   
   You can refer to this snippet for context:  
   https://github.com/apache/qpid-jms/blob/a248f02a21e1c9ca362fe317ad581d662c71d62c/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java#L1281-L1291
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret commented on PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#issuecomment-2826509049

   I'll try to cut a release and submit it for a vote. It's a mostly manual process, reserved for official Apache Committers. Feel free to send me an email (you can find my address on my GitHub profile), and I’ll cc you on the voting thread so you can stay updated on the release process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQNET-817 - Ability to configure hostname [activemq-nms-amqp]

Posted by "Havret (via GitHub)" <gi...@apache.org>.
Havret merged PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact