[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked

[GitBox <gi...@apache.org>]

andyvuong commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked
URL: https://github.com/apache/lucene-solr/pull/1238#discussion_r374929604
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
 ##########
 @@ -79,14 +80,19 @@ public void test() throws Exception {
     waitForState("Expected 'shard1' to be removed", collection, (n, c) -> {
       return c.getSlice("shard1") == null;
     });
+    
+    // verify shard1 znodes are deleted
+    assertShardZnodesDeleted(collection, "shard1");
 
     // Can delete a shard under construction
     setSliceState(collection, "shard2", Slice.State.CONSTRUCTION);
     CollectionAdminRequest.deleteShard(collection, "shard2").process(cluster.getSolrClient());
     waitForState("Expected 'shard2' to be removed", collection, (n, c) -> {
       return c.getSlice("shard2") == null;
     });
-
+    
+    // verify shard2 znodes are deleted
+    assertShardZnodesDeleted(collection, "shard");
 
 Review comment:
   Good catch, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org