You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/09/01 07:52:48 UTC

[GitHub] zeppelin pull request #1392: WIP [ZEPPELIN-1339] Multi-user note management

GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/1392

    WIP [ZEPPELIN-1339] Multi-user note management

    ### What is this PR for?
    This PR addresses multi-user note management in Zeppelin. The idea is to apply filtering for notes per user based on the overall note permissions specified. there're alternative approaches as well (e.g. #1390), the point is to come to common terms with performant and flexible design. 
    
    
    ### What type of PR is it?
    Feature
    
    ### Todos
    * [x] - skeleton
    * [ ] - add in memory per user view
    * [ ] - discuss on note permissions when created (public, private?)
    * [ ] - add more tests
    * [ ] - discussion on design
    
    ### What is the Jira issue?
    [Zeppelin-1339](https://issues.apache.org/jira/browse/ZEPPELIN-1339)
    
    ### How should this be tested?
    change some note permissions and should see different view for different users
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/multi-user-notes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1392
    
----
commit a7bcb60ca881becd20d9604b605c9f27ed7aa25a
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-09-01T07:29:57Z

    first draft

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1392: [ZEPPELIN-1437, 1438] Multi-user note management - use...

Posted by anthonycorbacho <gi...@git.apache.org>.

Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1392
  
    @Leemoonsoo is it possible to merge it in couple of hour? some of my work will depends on this PR :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---