You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/23 19:47:17 UTC
[commons-ognl] branch master updated: [test] Throw a specialized RuntimeException instead of RuntimeException
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git
The following commit(s) were added to refs/heads/master by this push:
new 216f015 [test] Throw a specialized RuntimeException instead of RuntimeException
216f015 is described below
commit 216f015747d03664408bbba48cc7f00b0710efef
Author: Gary Gregory <gg...@rocketsoftware.com>
AuthorDate: Fri Jun 23 15:47:13 2023 -0400
[test] Throw a specialized RuntimeException instead of
RuntimeException
---
.../org/apache/commons/ognl/test/PropertyNotFoundTest.java | 4 +++-
src/test/java/org/apache/commons/ognl/test/QuotingTest.java | 10 ++++++----
src/test/java/org/apache/commons/ognl/test/SetterTest.java | 12 +++++++++---
.../apache/commons/ognl/test/SetterWithConversionTest.java | 10 ++++++----
4 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/src/test/java/org/apache/commons/ognl/test/PropertyNotFoundTest.java b/src/test/java/org/apache/commons/ognl/test/PropertyNotFoundTest.java
index 501a6c2..94b6dbd 100644
--- a/src/test/java/org/apache/commons/ognl/test/PropertyNotFoundTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/PropertyNotFoundTest.java
@@ -18,6 +18,8 @@
*/
package org.apache.commons.ognl.test;
+import static org.junit.Assert.fail;
+
import java.util.ArrayList;
import java.util.Collection;
import java.util.Map;
@@ -132,7 +134,7 @@ public class PropertyNotFoundTest
break;
default:
- throw new RuntimeException( "don't understand TEST format with length " + element.length );
+ fail( "don't understand TEST format with length " + element.length );
}
data.add( tmp );
diff --git a/src/test/java/org/apache/commons/ognl/test/QuotingTest.java b/src/test/java/org/apache/commons/ognl/test/QuotingTest.java
index 63f63bd..789a010 100644
--- a/src/test/java/org/apache/commons/ognl/test/QuotingTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/QuotingTest.java
@@ -18,14 +18,16 @@
*/
package org.apache.commons.ognl.test;
+import static org.junit.Assert.fail;
+
+import java.util.ArrayList;
+import java.util.Collection;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
-import java.util.ArrayList;
-import java.util.Collection;
-
@RunWith(value = Parameterized.class)
public class QuotingTest
extends OgnlTestCase
@@ -68,7 +70,7 @@ public class QuotingTest
break;
default:
- throw new RuntimeException( "don't understand TEST format with length " + element.length );
+ fail( "don't understand TEST format with length " + element.length );
}
data.add( tmp );
diff --git a/src/test/java/org/apache/commons/ognl/test/SetterTest.java b/src/test/java/org/apache/commons/ognl/test/SetterTest.java
index 90e0e29..27c2827 100644
--- a/src/test/java/org/apache/commons/ognl/test/SetterTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/SetterTest.java
@@ -18,6 +18,14 @@
*/
package org.apache.commons.ognl.test;
+import static org.junit.Assert.fail;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Set;
+
import org.apache.commons.ognl.InappropriateExpressionException;
import org.apache.commons.ognl.NoSuchPropertyException;
import org.apache.commons.ognl.test.objects.Root;
@@ -25,8 +33,6 @@ import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
-import java.util.*;
-
@RunWith(value = Parameterized.class)
public class SetterTest
extends OgnlTestCase
@@ -97,7 +103,7 @@ public class SetterTest
break;
default:
- throw new RuntimeException( "don't understand TEST format with length " + element.length );
+ fail( "don't understand TEST format with length " + element.length );
}
data.add( tmp );
diff --git a/src/test/java/org/apache/commons/ognl/test/SetterWithConversionTest.java b/src/test/java/org/apache/commons/ognl/test/SetterWithConversionTest.java
index 2c1f3da..42671de 100644
--- a/src/test/java/org/apache/commons/ognl/test/SetterWithConversionTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/SetterWithConversionTest.java
@@ -18,14 +18,16 @@
*/
package org.apache.commons.ognl.test;
+import static org.junit.Assert.fail;
+
+import java.util.ArrayList;
+import java.util.Collection;
+
import org.apache.commons.ognl.test.objects.Root;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
-import java.util.ArrayList;
-import java.util.Collection;
-
@RunWith(value = Parameterized.class)
public class SetterWithConversionTest
extends OgnlTestCase
@@ -80,7 +82,7 @@ public class SetterWithConversionTest
break;
default:
- throw new RuntimeException("don't understand TEST format with length " + TEST.length);
+ fail("don't understand TEST format with length " + TEST.length);
}
data.add(tmp);