You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "WweiL (via GitHub)" <gi...@apache.org> on 2023/08/10 20:44:16 UTC

[GitHub] [spark] WweiL commented on a diff in pull request #42437: [SPARK-43032][FOLLOWUP][SS][CONNECT] StreamingQueryManager bug fix

WweiL commented on code in PR #42437:
URL: https://github.com/apache/spark/pull/42437#discussion_r1290660230


##########
python/pyspark/sql/tests/streaming/test_streaming.py:
##########
@@ -315,6 +315,19 @@ def _assert_exception_tree_contains_msg_default(self, exception, msg):
             contains = msg in e.desc
         self.assertTrue(contains, "Exception tree doesn't contain the expected message: %s" % msg)
 
+    def test_query_manager_get(self):
+        df = self.spark.readStream.format("rate").load()
+        for q in self.spark.streams.active:
+            q.stop()

Review Comment:
   To make sure there is no other running queries for test reasons. I see this used in other places of the tests too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org