You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zimmermatt <gi...@git.apache.org> on 2017/05/02 23:57:23 UTC

[GitHub] flink pull request #3811: [FLINK-5718] [core] TaskManagers exit the JVM on f...

GitHub user zimmermatt opened a pull request:

    https://github.com/apache/flink/pull/3811

    [FLINK-5718] [core] TaskManagers exit the JVM on fatal exceptions.

    Manually applied and adapted commit dfc6fba5b9830e6a7804a6a0c9f69b36bf772730 for
    the `release-1.2` branch.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zimmermatt/flink release-1.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3811
    
----
commit d50acea7ab7d53454de761a4391159ab81dbd63c
Author: Matt Zimmer <zi...@netflix.com>
Date:   2017-05-02T23:46:13Z

    [FLINK-5718] [core] TaskManagers exit the JVM on fatal exceptions.
    
    Manually applied and adapted commit dfc6fba5b9830e6a7804a6a0c9f69b36bf772730 for
    the `release-1.2` branch.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3811: [FLINK-5718] [core] TaskManagers exit the JVM on fatal ex...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3811
  
    Thanks for your contribution @zimmermatt. Changes look good to me. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3811: [FLINK-5718] [core] TaskManagers exit the JVM on fatal ex...

Posted by zimmermatt <gi...@git.apache.org>.
Github user zimmermatt commented on the issue:

    https://github.com/apache/flink/pull/3811
  
    Done @tillrohrmann. This is my first github pull request, so I didn't know I needed to do that manually :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3811: [FLINK-5718] [core] TaskManagers exit the JVM on f...

Posted by zimmermatt <gi...@git.apache.org>.
Github user zimmermatt closed the pull request at:

    https://github.com/apache/flink/pull/3811


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3811: [FLINK-5718] [core] TaskManagers exit the JVM on fatal ex...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3811
  
    Only for PR which are opened against another branch than `master`. For `master` I can close it. Thanks again for your work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3811: [FLINK-5718] [core] TaskManagers exit the JVM on f...

Posted by zimmermatt <gi...@git.apache.org>.
GitHub user zimmermatt reopened a pull request:

    https://github.com/apache/flink/pull/3811

    [FLINK-5718] [core] TaskManagers exit the JVM on fatal exceptions.

    Manually applied and adapted commit dfc6fba5b9830e6a7804a6a0c9f69b36bf772730 for
    the `release-1.2` branch.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zimmermatt/flink release-1.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3811
    
----
commit d50acea7ab7d53454de761a4391159ab81dbd63c
Author: Matt Zimmer <zi...@netflix.com>
Date:   2017-05-02T23:46:13Z

    [FLINK-5718] [core] TaskManagers exit the JVM on fatal exceptions.
    
    Manually applied and adapted commit dfc6fba5b9830e6a7804a6a0c9f69b36bf772730 for
    the `release-1.2` branch.

commit fb3d99002e289b667e7a1533277e90d6186751e8
Author: Matt Zimmer <zi...@netflix.com>
Date:   2017-05-03T18:04:17Z

    Merge remote-tracking branch 'upstream/release-1.2' into release-1.2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3811: [FLINK-5718] [core] TaskManagers exit the JVM on f...

Posted by zimmermatt <gi...@git.apache.org>.
Github user zimmermatt closed the pull request at:

    https://github.com/apache/flink/pull/3811


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3811: [FLINK-5718] [core] TaskManagers exit the JVM on fatal ex...

Posted by zimmermatt <gi...@git.apache.org>.
Github user zimmermatt commented on the issue:

    https://github.com/apache/flink/pull/3811
  
    @tillrohrmann, this is the port of FLINK-5718 to the `release-1.2` branch I mentioned.  It mostly transferred over, but I needed to make some judgement calls in `TaskManagerConfiguration`, `TaskManagerRuntimeInfo`, and `JvmExitOnFatalErrorTest`.
    
    Please let me know if you see anything that should be done differently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3811: [FLINK-5718] [core] TaskManagers exit the JVM on fatal ex...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3811
  
    I've merged your PR. Please close this PR since it does not get closed automatically if the commit is not merged into the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---