You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 05:43:44 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #615: use Into as argument type wherever applicable

houqp commented on a change in pull request #615:
URL: https://github.com/apache/arrow-datafusion/pull/615#discussion_r658489425



##########
File path: datafusion/src/execution/context.rs
##########
@@ -511,9 +515,10 @@ impl ExecutionContext {
     pub async fn write_parquet(
         &self,
         plan: Arc<dyn ExecutionPlan>,
-        path: String,
+        path: impl Into<String>,
         writer_properties: Option<WriterProperties>,
     ) -> Result<()> {
+        let path = path.into();

Review comment:
       yep, good call, i didn't double check whether the logic actually needs the ownership :+1: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org