You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "hgaol (via GitHub)" <gi...@apache.org> on 2023/03/28 14:27:57 UTC
[GitHub] [eventmesh] hgaol opened a new pull request, #3544: [fix] Fix CI issues
hgaol opened a new pull request, #3544:
URL: https://github.com/apache/eventmesh/pull/3544
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #<XXXX>.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151318086
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
Seems you're right. Since there's no response body, the length should be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151315088
##########
.github/workflows/eventmesh-server-go.yml:
##########
@@ -1,52 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-
-name: "Continuous Integration of EventMesh Server Go"
-
-on:
- push:
- branches: ['*']
- pull_request:
- branches: ['*']
-
-jobs:
- build:
- name: Build
- runs-on: ubuntu-latest
-
- steps:
- - name: Checkout repository
- uses: actions/checkout@v3
-
- - uses: actions/setup-go@v3
- with:
- go-version-file: 'eventmesh-server-go/go.mod'
- - run: go version
-
- - name: Download components
- run: go mod tidy
- working-directory: eventmesh-server-go
-
- - name: Build application
- run: make build
- working-directory: eventmesh-server-go
-
- - name: Test application
- run: make test
- working-directory: eventmesh-server-go
Review Comment:
Why should this file be deleted? Already have an alternate function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151362865
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151314266
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
After the replacement, does result.getBytes().length not need to be calculated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 merged pull request #3544: [fix] Fix CI issues
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#issuecomment-1487824443
will rebase newest master branch and resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151320392
##########
.github/workflows/eventmesh-server-go.yml:
##########
@@ -1,52 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-
-name: "Continuous Integration of EventMesh Server Go"
-
-on:
- push:
- branches: ['*']
- pull_request:
- branches: ['*']
-
-jobs:
- build:
- name: Build
- runs-on: ubuntu-latest
-
- steps:
- - name: Checkout repository
- uses: actions/checkout@v3
-
- - uses: actions/setup-go@v3
- with:
- go-version-file: 'eventmesh-server-go/go.mod'
- - run: go version
-
- - name: Download components
- run: go mod tidy
- working-directory: eventmesh-server-go
-
- - name: Build application
- run: make build
- working-directory: eventmesh-server-go
-
- - name: Test application
- run: make test
- working-directory: eventmesh-server-go
Review Comment:
Ok, I'm going to sync the warehouse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mytang0 commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151322521
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
> BTW, the CI takes too much time to run...
Thanks for feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151317527
##########
.github/workflows/eventmesh-server-go.yml:
##########
@@ -1,52 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-
-name: "Continuous Integration of EventMesh Server Go"
-
-on:
- push:
- branches: ['*']
- pull_request:
- branches: ['*']
-
-jobs:
- build:
- name: Build
- runs-on: ubuntu-latest
-
- steps:
- - name: Checkout repository
- uses: actions/checkout@v3
-
- - uses: actions/setup-go@v3
- with:
- go-version-file: 'eventmesh-server-go/go.mod'
- - run: go version
-
- - name: Download components
- run: go mod tidy
- working-directory: eventmesh-server-go
-
- - name: Build application
- run: make build
- working-directory: eventmesh-server-go
-
- - name: Test application
- run: make test
- working-directory: eventmesh-server-go
Review Comment:
I found `eventmesh-server-go` has been deleted from the newest master branch. And it will fail due to not found the folder/files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151318245
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
BTW, the CI takes too much time to run...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] hgaol commented on a diff in pull request #3544: [fix] Fix CI issues
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on code in PR #3544:
URL: https://github.com/apache/eventmesh/pull/3544#discussion_r1151318245
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java:
##########
@@ -103,7 +103,7 @@ void delete(HttpExchange httpExchange) throws IOException {
Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
httpExchange.sendResponseHeaders(500, result.getBytes().length);
- out.write(result.getBytes());
+ log.error(result);
Review Comment:
BTW, the CI took too much time to run...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org