You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/11 08:49:09 UTC

[GitHub] [iotdb] ericpai opened a new pull request #4357: [IOTDB-1983] Fix DescReadWriteBatchData serializing bug

ericpai opened a new pull request #4357:
URL: https://github.com/apache/iotdb/pull/4357


   See JIRA: https://issues.apache.org/jira/browse/IOTDB-1983
   
   Fix bugs:
   1. Incorrect order of serializing `DescReadWriteBatchData`.
   2. Unsupport **VECTOR** type of `DescReadWriteBatchData`.
   3. Add unit test cases to cover the `BatchData` and its children classes.
   4. Add some comments to make the `getXXXByIndex()` interfaces more clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 merged pull request #4357: [IOTDB-1983] Fix DescReadWriteBatchData serializing bug

Posted by GitBox <gi...@apache.org>.

JackieTien97 merged pull request #4357:
URL: https://github.com/apache/iotdb/pull/4357


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4357: [IOTDB-1983] Fix DescReadWriteBatchData serializing bug

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #4357:
URL: https://github.com/apache/iotdb/pull/4357#issuecomment-966154107


   
   [![Coverage Status](https://coveralls.io/builds/44188614/badge)](https://coveralls.io/builds/44188614)
   
   Coverage increased (+0.03%) to 66.715% when pulling **655c52024491a30bcacb7ad1b8fe71be093bff4b on ericpai:bugfix/iotdb-1983** into **7f936db499ed1b9c0863dcdce64799a3349a55aa on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai commented on pull request #4357: [IOTDB-1983] Fix DescReadWriteBatchData serializing bug

Posted by GitBox <gi...@apache.org>.

ericpai commented on pull request #4357:
URL: https://github.com/apache/iotdb/pull/4357#issuecomment-966103465


   @Alima777 @JackieTien97 Please review this fix, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org