You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/07 08:27:35 UTC

[GitHub] [hadoop] dbtsai opened a new pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

dbtsai opened a new pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201


   See https://issues.apache.org/jira/browse/HADOOP-17125 for details


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675345547


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675345307


   @sunchao thanks! That helps a lot. I rebased on trunk, and modified the script to remove snappy native build. Let's see how it works.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675611383


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hemanthboyina commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hemanthboyina commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670831875


   ideally there shouldn't be any difference in performance , better we have a benchmark result of native snappy and java-snappy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-678534108


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  29m 35s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m  7s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 21s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  16m 59s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 56s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 35s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  14m  9s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 28s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  5s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 32s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 23s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 32s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  20m 47s |  the patch passed  |
   | +1 :green_heart: |  compile  |  19m  0s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  19m  0s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 17 new + 144 unchanged - 17 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  19m  0s |  the patch passed  |
   | +1 :green_heart: |  javac  |  19m  0s |  the patch passed  |
   | +1 :green_heart: |  compile  |  16m 59s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  16m 59s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 39 new + 122 unchanged - 39 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  16m 59s |  the patch passed  |
   | +1 :green_heart: |  javac  |  16m 59s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   2m 51s |  root: The patch generated 3 new + 138 unchanged - 5 fixed = 141 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  3s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  17m 34s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 18s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  14m 13s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 23s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 15s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 24s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 569m 23s |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 37s |  The patch generated 1 ASF License warnings.  |
   |  |   | 898m 55s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell |
   |   | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | hadoop.yarn.client.api.impl.TestAMRMClient |
   |   | hadoop.mapred.nativetask.kvtest.LargeKVTest |
   |   | hadoop.mapred.nativetask.kvtest.KVTest |
   |   | hadoop.mapred.nativetask.compresstest.CompressTest |
   |   | hadoop.yarn.sls.appmaster.TestAMSimulator |
   |   | hadoop.io.compress.TestCodec |
   |   | hadoop.io.compress.snappy.TestSnappyCompressorDecompressor |
   |   | hadoop.io.compress.TestCompressorDecompressor |
   |   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
   |   | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
   |   | hadoop.hdfs.TestGetFileChecksum |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux cec481d8c332 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / f734455e5d7 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 4209 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] iwasakims commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-681687572


   Removing the snappy related code from hadoop-mapreduce-client-nativetask breaks existing deployment using the feature? Since imcompatible change is hard to get consensus and takes time to come in, how about fixing only hadoop-common first and keeping hadoop-mapreduce-client-nativetask as is here?
   
   BUILDING.txt should refer snappy-dev(el) as optional dependency only used for hadoop-mapreduce-client-nativetask in that case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] viirya commented on a change in pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#discussion_r485738846



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);
+      // There is compressed input, decompress it now.
+      int size = Snappy.uncompressedLength((ByteBuffer) compressedDirectBuf);
+      if (size > uncompressedDirectBuf.capacity()) {

Review comment:
       `decompressDirect` also calls `decompressBytesDirect`, but the `uncompressedDirectBuf` is passed in as an argument. I think it has danger to assume `uncompressedDirectBuf` is always reset.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675376588


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675956158


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  25m 55s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m  1s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 35s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  17m  2s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 56s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 57s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  14m 28s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 26s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  3s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 32s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 26s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 32s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 36s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  21m  5s |  the patch passed  |
   | +1 :green_heart: |  compile  |  19m  2s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  19m  2s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 15 new + 146 unchanged - 15 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  19m  2s |  the patch passed  |
   | +1 :green_heart: |  javac  |  19m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m  7s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  17m  7s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 16 new + 145 unchanged - 16 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  17m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |  17m  7s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   2m 53s |  root: The patch generated 11 new + 140 unchanged - 3 fixed = 151 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  4s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  17m 39s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 19s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  6s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  13m 56s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 23s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  8s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 24s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 588m 26s |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 43s |  The patch generated 1 ASF License warnings.  |
   |  |   | 915m 33s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell |
   |   | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
   |   | hadoop.mapred.nativetask.kvtest.LargeKVTest |
   |   | hadoop.mapred.nativetask.kvtest.KVTest |
   |   | hadoop.mapred.nativetask.compresstest.CompressTest |
   |   | hadoop.yarn.sls.TestReservationSystemInvariants |
   |   | hadoop.io.compress.TestCompressorDecompressor |
   |   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
   |   | hadoop.hdfs.server.datanode.TestBPOfferService |
   |   | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
   |   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
   |   | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
   |   | hadoop.hdfs.TestGetFileChecksum |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 1bf45086a94c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / b65e43fe386 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 4435 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/7/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] sunchao edited a comment on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
sunchao edited a comment on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675230696






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on a change in pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#discussion_r485364827



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);
+      // There is compressed input, decompress it now.
+      int size = Snappy.uncompressedLength((ByteBuffer) compressedDirectBuf);
+      if (size > uncompressedDirectBuf.capacity()) {

Review comment:
       Before calling `decompressBytesDirect`, we always reset `uncompressedDirectBuf`. So both method returns the same result. But you are right, I think .remaining is better. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] viirya commented on a change in pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#discussion_r485760840



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);

Review comment:
       For `decompressDirect`, `compressedDirectBuf` is set up correctly before calling `decompressBytesDirect`. So we don't need to do it here again. For `decompress`, I'm not sure, but looks like `setInputFromSavedData` also takes care about `compressedDirectBuf` reseting. I guess we don't need to do it in `decompressBytesDirect`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-685098411


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 5 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 36s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 46s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  16m 58s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 47s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  6s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 37s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 11s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   2m 14s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 38s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | -0 :warning: |  patch  |   2m 35s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m  4s |  the patch passed  |
   | -1 :x: |  compile  |   1m  5s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m  5s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 59s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   0m 59s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | +1 :green_heart: |  checkstyle  |   2m 22s |  root: The patch generated 0 new + 151 unchanged - 5 fixed = 151 total (was 156)  |
   | +1 :green_heart: |  mvnsite  |   1m 23s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  14m  1s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 19s |  hadoop-project has no data from findbugs  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 18s |  hadoop-project in the patch passed.  |
   | -1 :x: |  unit  |   0m 43s |  hadoop-common in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 34s |  The patch does not generate ASF License warnings.  |
   |  |   | 124m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 85761ea227bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / c7dab2b23e4 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/testReport/ |
   | Max. process+thread count | 431 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-common-project/hadoop-common U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/14/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on a change in pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#discussion_r485363709



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);

Review comment:
       `decompressBytesDirect` is the only call that reads the data from `compressedDirectBuf`, so I think we should read it from the beginning. In `compressedDirectBuf`, we should fully decompress the  `compressedDirectBuf`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675487358


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 40s |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 15s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  20m 57s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   3m 45s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  25m 25s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 49s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   8m 20s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   9m  2s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 32s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 21s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 31s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  20m 50s |  the patch passed  |
   | -1 :x: |  compile  |   1m 18s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  cc  |   1m 18s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  golang  |   1m 18s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m 18s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  cc  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  golang  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   2m 38s |  root: The patch generated 11 new + 140 unchanged - 3 fixed = 151 total (was 143)  |
   | +1 :green_heart: |  mvnsite  |  17m 16s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 18s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  14m  8s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 24s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  2s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 21s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   7m  6s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m  7s |  The patch does not generate ASF License warnings.  |
   |  |   | 304m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux b9047c9c6497 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / fefacf2578e |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/testReport/ |
   | Max. process+thread count | 414 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/5/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] viirya commented on a change in pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#discussion_r485253169



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);
+      // There is compressed input, decompress it now.
+      int size = Snappy.uncompressedLength((ByteBuffer) compressedDirectBuf);
+      if (size > uncompressedDirectBuf.capacity()) {

Review comment:
       Should we check with `uncompressedDirectBuf.remaining` instead of `capacity`?

##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/snappy/SnappyDecompressor.java
##########
@@ -276,13 +258,27 @@ public void end() {
     // do nothing
   }
 
-  private native static void initIDs();
+  private int decompressBytesDirect() throws IOException {
+    if (compressedDirectBufLen == 0) {
+      return 0;
+    } else {
+      // Set the position and limit of `compressedDirectBuf` for reading
+      compressedDirectBuf.position(0).limit(compressedDirectBufLen);

Review comment:
       I'm not sure we need to set position and limit here? If `compressedDirectBuf` already has been set with position and limit before calling `decompressBytesDirect`? Won't we read wrong data from this buffer?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] iwasakims commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-681685716


   Thanks for working on this,  @dbtsai.
   
   Then patch breaks build if snappy(-devel) is installed on the env. hadoop-common-project/hadoop-common/src/CMakeLists.txt must be updated to address this.
   
   ```
   [WARNING] CMake Error at /srcs/hadoop/hadoop-common-project/hadoop-common/HadoopCommon.cmake:60 (add_library):
   [WARNING]   Cannot find source file:
   [WARNING] 
   [WARNING]     main/native/src/org/apache/hadoop/io/compress/snappy/SnappyCompressor.c
   ...
   [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.4.0-SNAPSHOT:cmake-compile (cmake-compile) on project hadoop-common: CMake failed with error code 1 -> [Help 1]
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-690780546


   Closing this PR in favor of https://github.com/apache/hadoop/pull/2297


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-679837262


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-680314265


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  32m 10s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 16s |  trunk passed  |
   | +1 :green_heart: |  compile  |  21m 18s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  19m  8s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 58s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  23m  9s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 44s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   7m  7s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 16s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 23s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 20s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 23s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  23m 42s |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 19s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  20m 19s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 30 new + 131 unchanged - 30 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  20m 19s |  the patch passed  |
   | +1 :green_heart: |  javac  |  20m 19s |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 47s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  17m 47s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 7 new + 154 unchanged - 7 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  17m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |  17m 47s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   2m 56s |  root: The patch generated 1 new + 138 unchanged - 5 fixed = 139 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  4s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  18m 17s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 15s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 42s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 29s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  4s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 17s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 18s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 610m 58s |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   2m 22s |  The patch generated 1 ASF License warnings.  |
   |  |   | 967m 14s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | hadoop.io.compress.TestCompressorDecompressor |
   |   | hadoop.io.compress.TestCodec |
   |   | hadoop.io.compress.snappy.TestSnappyCompressorDecompressor |
   |   | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
   |   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
   |   | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
   |   | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.TestGetFileChecksum |
   |   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination |
   |   | hadoop.mapred.nativetask.kvtest.KVTest |
   |   | hadoop.mapred.nativetask.kvtest.LargeKVTest |
   |   | hadoop.mapred.nativetask.compresstest.CompressTest |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 42fe8d1e8869 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / a932796d0ca |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 3033 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670468155


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 26s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 57s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 25s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  16m 49s |  trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09  |
   | +1 :green_heart: |  checkstyle  |   2m 34s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 46s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 30s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 48s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 39s |  trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09  |
   | +0 :ok: |  spotbugs  |   0m 29s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 29s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 29s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 36s |  the patch passed  |
   | -1 :x: |  compile  |   1m  3s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  cc  |   1m  3s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  golang  |   1m  3s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m  3s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 53s |  root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.  |
   | -1 :x: |  cc  |   0m 53s |  root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.  |
   | -1 :x: |  golang  |   0m 53s |  root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.  |
   | -1 :x: |  javac  |   0m 53s |  root in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.  |
   | -0 :warning: |  checkstyle  |   2m 19s |  root: The patch generated 10 new + 113 unchanged - 2 fixed = 123 total (was 115)  |
   | +1 :green_heart: |  mvnsite  |   1m 53s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  13m 54s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  2s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 57s |  the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09  |
   | +0 :ok: |  findbugs  |   0m 14s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 14s |  hadoop-project-dist has no data from findbugs  |
   | -1 :x: |  findbugs  |   2m 10s |  hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 12s |  hadoop-project in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 12s |  hadoop-project-dist in the patch passed.  |
   | -1 :x: |  unit  |   0m 36s |  hadoop-common in the patch failed.  |
   | +1 :green_heart: |  unit  |   2m 49s |  hadoop-mapreduce-client-nativetask in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 30s |  The patch does not generate ASF License warnings.  |
   |  |   | 129m 45s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-common-project/hadoop-common |
   |  |  Unread field:field be static?  At SnappyCodec.java:[line 38] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 2bf362b831ab 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 81da221c757 |
   | Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/diff-checkstyle-root.txt |
   | findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/testReport/ |
   | Max. process+thread count | 456 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/2/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-680407386


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-681060463


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  33m  6s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  27m 58s |  trunk passed  |
   | +1 :green_heart: |  compile  |  21m 52s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  18m  9s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 55s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  22m 12s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 23s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   7m 38s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 45s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 29s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 21s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 29s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  26m 17s |  the patch passed  |
   | +1 :green_heart: |  compile  |  23m 14s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  23m 14s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 37 new + 124 unchanged - 37 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  23m 14s |  the patch passed  |
   | +1 :green_heart: |  javac  |  23m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 47s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  20m 47s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 12 new + 149 unchanged - 12 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  20m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |  20m 47s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   3m 10s |  root: The patch generated 1 new + 138 unchanged - 5 fixed = 139 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  5s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  20m 25s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 19s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  6s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  17m  2s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   7m 29s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 57s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 22s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 24s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 661m 32s |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 50s |  The patch generated 1 ASF License warnings.  |
   |  |   | 1041m 48s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.mapred.nativetask.compresstest.CompressTest |
   |   | hadoop.mapred.nativetask.kvtest.KVTest |
   |   | hadoop.mapred.nativetask.kvtest.LargeKVTest |
   |   | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
   |   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.TestDecommissionWithBackoffMonitor |
   |   | hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor |
   |   | hadoop.hdfs.TestBlocksScheduledCounter |
   |   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
   |   | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby |
   |   | hadoop.io.compress.TestCodec |
   |   | hadoop.io.compress.TestCompressorDecompressor |
   |   | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
   |   | hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling |
   |   | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerOvercommit |
   |   | hadoop.yarn.applications.distributedshell.TestDistributedShell |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 9be12b288704 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 6a49bf9bffb |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 3504 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/11/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675796919


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  30m  0s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 16s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 15s |  trunk passed  |
   | +1 :green_heart: |  compile  |  20m 46s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  17m 38s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 58s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  21m 12s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 43s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 30s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  6s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 23s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 19s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 23s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  23m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 10s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  20m 11s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 28 new + 133 unchanged - 28 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  20m 10s |  the patch passed  |
   | +1 :green_heart: |  javac  |  20m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 43s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  17m 43s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 24 new + 137 unchanged - 24 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  17m 43s |  the patch passed  |
   | +1 :green_heart: |  javac  |  17m 43s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   2m 55s |  root: The patch generated 11 new + 140 unchanged - 3 fixed = 151 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  4s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  18m 16s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 14s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 47s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 26s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  1s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 17s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 18s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 592m 36s |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 25s |  The patch generated 1 ASF License warnings.  |
   |  |   | 938m 38s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell |
   |   | hadoop.io.compress.TestCompressorDecompressor |
   |   | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
   |   | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
   |   | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
   |   | hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes |
   |   | hadoop.hdfs.TestErasureCodeBenchmarkThroughput |
   |   | hadoop.mapred.nativetask.kvtest.KVTest |
   |   | hadoop.mapred.nativetask.kvtest.LargeKVTest |
   |   | hadoop.mapred.nativetask.compresstest.CompressTest |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 1d923ea1e899 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / fefacf2578e |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/testReport/ |
   | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 3073 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/6/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-678079827


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/8/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-679845927


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/10/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675270008


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  26m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 55s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 32s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  16m 55s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 59s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 47s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  14m 24s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 49s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 36s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 29s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 23s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 29s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 44s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  21m 32s |  the patch passed  |
   | -1 :x: |  compile  |   1m 17s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  cc  |   1m 17s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  golang  |   1m 17s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m 17s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  cc  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  golang  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   1m 12s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   2m 37s |  root: The patch generated 11 new + 140 unchanged - 3 fixed = 151 total (was 143)  |
   | +1 :green_heart: |  mvnsite  |  17m 29s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 19s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  14m 10s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 23s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m  9s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   7m  3s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m  9s |  The patch does not generate ASF License warnings.  |
   |  |   | 302m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux d59efa32fb0d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / b367942fe49 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/testReport/ |
   | Max. process+thread count | 470 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/4/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670685339


   @hemanthboyina The performance should be similar since the java-snappy also uses native lib that is bundled in the jar file. I don't benchmark yet, and I will try to find time to do it. If possible, feel free to do the testing and post the result back.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-671967655


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  25m 58s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 40s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 24s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  17m  0s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 56s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 30s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  14m 15s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 30s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 10s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 31s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 24s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | -1 :x: |  findbugs  |  31m 12s |  root in trunk has 2 extant findbugs warnings.  |
   | +0 :ok: |  findbugs  |   0m 31s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  21m  8s |  the patch passed  |
   | -1 :x: |  compile  |   1m 16s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  cc  |   1m 16s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  golang  |   1m 16s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m 16s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   1m 10s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  cc  |   1m 10s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  golang  |   1m 10s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   1m 10s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   2m 34s |  root: The patch generated 10 new + 113 unchanged - 2 fixed = 123 total (was 115)  |
   | +1 :green_heart: |  mvnsite  |  17m  8s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 19s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  13m 55s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   6m 22s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 10s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 23s |  hadoop-project-dist has no data from findbugs  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   7m  2s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m  8s |  The patch does not generate ASF License warnings.  |
   |  |   | 297m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux a63449d124fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 909f1e82d3e |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/branch-findbugs-root-warnings.html |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | golang | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/testReport/ |
   | Max. process+thread count | 431 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/3/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-683141909


   @iwasakims Good point. I'll revert the `hadoop-mapreduce-client-nativetask` change, and we can revisit it later. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hemanthboyina commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hemanthboyina commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-670567445


   thanks for the proposal and thanks for the PR
   have you done any performance test with native snappy and java snappy ? is there any sort of decrease or increase ?
   and in the PR , you can remove commented code checkins


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-680009024


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  34m 48s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 27s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 29s |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 56s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  17m 24s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 57s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  24m 45s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 14s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   8m  0s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   7m 53s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   0m 33s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 25s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 32s |  branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  21m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 20s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | -1 :x: |  cc  |  24m 20s |  root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 26 new + 135 unchanged - 26 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  24m 20s |  the patch passed  |
   | +1 :green_heart: |  javac  |  24m 20s |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 15s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | -1 :x: |  cc  |  22m 15s |  root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 10 new + 151 unchanged - 10 fixed = 161 total (was 161)  |
   | +1 :green_heart: |  golang  |  22m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |  22m 15s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   3m 14s |  root: The patch generated 1 new + 138 unchanged - 5 fixed = 139 total (was 143)  |
   | +1 :green_heart: |  hadolint  |   0m  5s |  There were no new hadolint issues.  |
   | +1 :green_heart: |  mvnsite  |  23m  2s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  shelldocs  |   0m 18s |  There were no new shelldocs issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  6s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  18m 18s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   8m 27s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   8m 58s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 20s |  hadoop-project has no data from findbugs  |
   | +0 :ok: |  findbugs  |   0m 21s |  hadoop-project-dist has no data from findbugs  |
   | -1 :x: |  findbugs  |  31m 25s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 37s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 53s |  The patch does not generate ASF License warnings.  |
   |  |   | 374m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit hadolint compile javac javadoc mvninstall shadedclient xml findbugs checkstyle cc golang |
   | uname | Linux 6d0aa68c135c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / a932796d0ca |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/diff-checkstyle-root.txt |
   | findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/patch-findbugs-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/artifact/out/patch-unit-root.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/testReport/ |
   | Max. process+thread count | 472 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/9/console |
   | versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6 hadolint=1.11.1-0-g0e692dd |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-685104813


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 16s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 5 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 58s |  trunk passed  |
   | +1 :green_heart: |  compile  |  22m 30s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |  17m 40s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   2m 52s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 53s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  20m 51s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 55s |  trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   2m 14s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 28s |  branch/hadoop-project no findbugs output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m  2s |  the patch passed  |
   | -1 :x: |  compile  |   1m  5s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   1m  5s |  root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 57s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   0m 57s |  root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   2m 38s |  root: The patch generated 2 new + 150 unchanged - 6 fixed = 152 total (was 156)  |
   | +1 :green_heart: |  mvnsite  |   1m 23s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 31s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  findbugs  |   0m 14s |  hadoop-project has no data from findbugs  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 13s |  hadoop-project in the patch passed.  |
   | -1 :x: |  unit  |   0m 40s |  hadoop-common in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 30s |  The patch does not generate ASF License warnings.  |
   |  |   | 132m 34s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2201 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle |
   | uname | Linux 27c4814e0fe9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / c7dab2b23e4 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt |
   | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/diff-checkstyle-root.txt |
   | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/testReport/ |
   | Max. process+thread count | 332 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-common-project/hadoop-common U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2201/15/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] sunchao commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201#issuecomment-675230696


   @dbtsai FYI #2226 has been merged - you can try build again


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] dbtsai closed pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec

Posted by GitBox <gi...@apache.org>.
dbtsai closed pull request #2201:
URL: https://github.com/apache/hadoop/pull/2201


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org