You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by aa...@apache.org on 2008/02/03 23:51:16 UTC

svn commit: r618115 - /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java

Author: aadamchik
Date: Sun Feb  3 14:51:13 2008
New Revision: 618115

URL: http://svn.apache.org/viewvc?rev=618115&view=rev
Log:
CAY-971 ROP GraphDiff "compressor"

Modified:
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java?rev=618115&r1=618114&r2=618115&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/graph/GraphDiffCompressor.java Sun Feb  3 14:51:13 2008
@@ -65,6 +65,10 @@
                     // if the node was inserted in the same transaction and later deleted,
                     // remove all its ops. Otherwise preserve arc ops (since delete rules
                     // depend on them), and delete operation itself.
+
+                    // TODO: andrus 2008/02/04 - this doesn't take into account a
+                    // possibility that a deleted node was re-inserted... Although I don't
+                    // see how this could possibly happen with the present Cayenne API.
                     if (createdNodes != null && createdNodes.contains(nodeId)) {
                         while (it.hasNext()) {
                             NodeDiff diff = (NodeDiff) it.next();