[GitHub] [metamodel] kaspersorensen commented on a change in pull request #241: (METAMODEL-1226) Metadata for numeric data types does not include num…

[GitBox <gi...@apache.org>]

kaspersorensen commented on a change in pull request #241:
URL: https://github.com/apache/metamodel/pull/241#discussion_r448475801



##########
File path: core/src/main/java/org/apache/metamodel/schema/Column.java
##########
@@ -85,6 +85,14 @@
      */
     public Integer getColumnSize();
 
+    /**
+     * Gets the number of decimal digits this column.

Review comment:
       Nit-pick: Missing a "for" (this column) in this sentence.

##########
File path: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcMetadataLoader.java
##########
@@ -383,6 +343,52 @@ private void loadColumns(JdbcTable table, DatabaseMetaData metaData) {
         }
     }
 
+    private void processColumn(JdbcTable table, boolean convertLobs, ResultSet rs, int columnNumber) throws SQLException {
+        final String columnName = rs.getString(4);
+        if (_identifierQuoteString == null && new StringTokenizer(columnName).countTokens() > 1) {
+            logger.warn("column name contains whitespace: \"" + columnName + "\".");
+        }
+
+        final int jdbcType = rs.getInt(5);
+        final String nativeType = rs.getString(6);
+        final Integer columnSize = rs.getInt(7);
+        Integer decimalDigits = rs.getInt(9);

Review comment:
       We should add `final` to this one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org