You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2015/05/06 10:10:00 UTC

[jira] [Resolved] (OAK-2831) Test classes extending AbstractImportTest do not always shut down repository instances properly

     [ https://issues.apache.org/jira/browse/OAK-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved OAK-2831.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0
         Assignee: Alex Parvulescu

thanks Robert for the patch! 
fixed with http://svn.apache.org/r1677944


> Test classes extending AbstractImportTest do not always shut down repository instances properly
> -----------------------------------------------------------------------------------------------
>
>                 Key: OAK-2831
>                 URL: https://issues.apache.org/jira/browse/OAK-2831
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: Robert Munteanu
>            Assignee: Alex Parvulescu
>             Fix For: 1.3.0
>
>         Attachments: OAK-2831-1.patch
>
>
> In {{AbstractImportTest}} a content repository instance is unconditionally created, see https://github.com/apache/jackrabbit-oak/blob/38670e11ed5682b49b7a4b37203aadcd89e1de44/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AbstractImportTest.java#L80-L83 . However, the repository is shutdown only if the import behaviour != null: https://github.com/apache/jackrabbit-oak/blob/38670e11ed5682b49b7a4b37203aadcd89e1de44/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AbstractImportTest.java#L133-L136 .
> This leads to executor instances not being closed and a large number of threads being leaked. I actually get consistent build failures due to this - see http://oak-dev.markmail.org/thread/k65wycf7ryxioob7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)