You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/06 01:53:04 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #10494: chore: TypeScript 

mistercrunch opened a new pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494


   Tried @rusackas 's approach of bringing a react-bootstrap component in Storybook just for fun.
   
   One thought is around the fact that labels are used in controls, and that it calls for eventually having to refactor components into its own package that other packages can depend on. 
   
   <img width="1407" alt="Screen Shot 2020-08-05 at 5 42 40 PM" src="https://user-images.githubusercontent.com/487433/89477830-18f96680-d743-11ea-8931-8c41a456f6e8.png">
   <img width="1337" alt="Screen Shot 2020-08-05 at 5 42 30 PM" src="https://user-images.githubusercontent.com/487433/89477834-1ac32a00-d743-11ea-8124-00dea8fc8c15.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#discussion_r466143602



##########
File path: superset-frontend/src/components/Label/label.stories.jsx
##########
@@ -30,16 +30,16 @@ export default {
 const bsStyleKnob = {
   label: 'Types',
   options: {
-    Danger: 'danger',
-    Warning: 'warning',
-    Success: 'success',
-    Default: 'default',
+    danger: 'danger',
+    warning: 'warning',
+    cuccess: 'success',

Review comment:
       ```suggestion
       success: 'success',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#discussion_r466821121



##########
File path: superset-frontend/src/components/Label/label.stories.jsx
##########
@@ -30,16 +30,16 @@ export default {
 const bsStyleKnob = {
   label: 'Types',
   options: {
-    Danger: 'danger',
-    Warning: 'warning',
-    Success: 'success',
-    Default: 'default',
+    danger: 'danger',
+    warning: 'warning',
+    cuccess: 'success',

Review comment:
       well that wasn't a success




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668983119






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-669640836


   I was just working with labels and wanted to make some tweaks. Having this would make it easier to add other styles to the label. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668986715


   Ugh... this python pre-commit hook is failing on a random text file. I'm fixing it in this in https://github.com/apache/incubator-superset/pull/10515


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668989916


   🏷 storybook


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668983119


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=h1) Report
   > Merging [#10494](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce10e13ec3973274a945cda7489618978babe78b&el=desc) will **decrease** coverage by `7.25%`.
   > The diff coverage is `81.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10494/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10494      +/-   ##
   ==========================================
   - Coverage   70.84%   63.59%   -7.26%     
   ==========================================
     Files         605      765     +160     
     Lines       32428    36178    +3750     
     Branches     3423     3441      +18     
   ==========================================
   + Hits        22975    23008      +33     
   - Misses       9341    13054    +3713     
   - Partials      112      116       +4     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | #cypress | `54.14% <94.44%> (-0.42%)` | :arrow_down: |
   | #javascript | `60.09% <81.48%> (+0.14%)` | :arrow_up: |
   | #python | `59.07% <ΓΈ> (-11.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | `87.17% <ΓΈ> (ΓΈ)` | |
   | [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `61.53% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <ΓΈ> (-1.22%)` | :arrow_down: |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
   | [...et-frontend/src/components/Label/label.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvbGFiZWwuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ΓΈ)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `84.96% <ΓΈ> (ΓΈ)` | |
   | [superset-frontend/src/components/Timer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIuanN4) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `71.00% <0.00%> (ΓΈ)` | |
   | ... and [206 more](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=footer). Last update [ce10e13...5ea51b0](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668977292


   I believe I've fixed last test... if this gets merged in, remind me to open another PR and use the new `syledMount` helper all over the place.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-668983119


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=h1) Report
   > Merging [#10494](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce10e13ec3973274a945cda7489618978babe78b&el=desc) will **decrease** coverage by `7.15%`.
   > The diff coverage is `81.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10494/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10494      +/-   ##
   ==========================================
   - Coverage   70.84%   63.69%   -7.16%     
   ==========================================
     Files         605      765     +160     
     Lines       32428    36178    +3750     
     Branches     3423     3441      +18     
   ==========================================
   + Hits        22975    23043      +68     
   - Misses       9341    13022    +3681     
   - Partials      112      113       +1     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | #cypress | `54.64% <94.44%> (+0.08%)` | :arrow_up: |
   | #javascript | `60.09% <81.48%> (+0.14%)` | :arrow_up: |
   | #python | `59.07% <ΓΈ> (-11.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | `87.17% <ΓΈ> (ΓΈ)` | |
   | [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `61.53% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.33% <ΓΈ> (ΓΈ)` | |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <ΓΈ> (ΓΈ)` | |
   | [...et-frontend/src/components/Label/label.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvbGFiZWwuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ΓΈ)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `84.96% <ΓΈ> (ΓΈ)` | |
   | [superset-frontend/src/components/Timer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIuanN4) | `100.00% <ΓΈ> (ΓΈ)` | |
   | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `71.00% <0.00%> (ΓΈ)` | |
   | ... and [198 more](https://codecov.io/gh/apache/incubator-superset/pull/10494/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=footer). Last update [ce10e13...5ea51b0](https://codecov.io/gh/apache/incubator-superset/pull/10494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch closed pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
mistercrunch closed pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai edited a comment on pull request #10494: chore: TypeScript

Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #10494:
URL: https://github.com/apache/incubator-superset/pull/10494#issuecomment-669640836


   I was just working with labels and wanted to make some tweaks. Having this in place would make it easy to add more variants


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org