You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "KevinyhZou (via GitHub)" <gi...@apache.org> on 2025/08/28 06:04:59 UTC
[PR] [GLUTEN-10570][FLINK]Fix UT failure on jdk17 [incubator-gluten]
KevinyhZou opened a new pull request, #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
fix flink ut failure on jdk17
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the corresponding issue
when the PR is merged.
-->
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE closed pull request #10572: [GLUTEN-10570][FLINK] Fix UT failure on JDK 17
URL: https://github.com/apache/incubator-gluten/pull/10572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "KevinyhZou (via GitHub)" <gi...@apache.org>.
KevinyhZou commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3251449461
I have added some possible options in flink.yml, please help to review it. @PHILO-HE @jinchengchenghh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK]Fix UT failure on jdk17 [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3232019319
https://github.com/apache/incubator-gluten/issues/10570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3249573817
I think @PHILO-HE means adding all of possible options in https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Add `--add-opens` options to MAVEN_OPTS for Java 17 compatibility [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3237138106
Maybe you also need, otherwise you may meet exception in the future, not sure for that.
```
'--add-opens=java.base/java.lang=ALL-UNNAMED' \
'--add-opens=java.base/java.lang.invoke=ALL-UNNAMED' \
'--add-opens=java.base/java.lang.reflect=ALL-UNNAMED' \
'--add-opens=java.base/java.io=ALL-UNNAMED' \
'--add-opens=java.base/java.net=ALL-UNNAMED' \
'--add-opens=java.base/java.nio=ALL-UNNAMED' \
'--add-opens=java.base/java.util=ALL-UNNAMED' \
'--add-opens=java.base/java.util.concurrent=ALL-UNNAMED' \
'--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED' \
'--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED' \
'--add-opens=java.base/sun.nio.ch=ALL-UNNAMED' \
'--add-opens=java.base/sun.nio.cs=ALL-UNNAMED' \
'--add-opens=java.base/sun.security.action=ALL-UNNAMED' \
'--add-opens=java.base/sun.util.calendar=ALL-UNNAMED' \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "KevinyhZou (via GitHub)" <gi...@apache.org>.
KevinyhZou commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3253373836
> @KevinyhZou, thanks for your update. Do we need to add these args in `gluten-flink/ut/pom.xml`, similar to the following? Assume they are required for developers to run `mvn test` with Java 17 in the local.
>
> https://github.com/apache/incubator-gluten/blob/7f5fb2d8a98d1410072858244235363530868593/pom.xml#L1622
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK]Fix UT failure on jdk17 [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3233542718
Flink CI is using JDK 17. I'm curious why this issue is not reported by CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3252462598
@KevinyhZou, thanks for you update. Do we need to add these args in `gluten-flink/ut/pom.xml`, similar to the following? Assume they are required for developers to run `mvn test` with Java 17 in the local.
https://github.com/apache/incubator-gluten/blob/7f5fb2d8a98d1410072858244235363530868593/pom.xml#L1622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "KevinyhZou (via GitHub)" <gi...@apache.org>.
KevinyhZou commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3241986270
> @jinchengchenghh, I just became aware of this. The current Flink CI has already added some Maven arguments (including the proposed args of this PR) that ensure compilation and tests pass on JDK 17. See the link below.
>
> @KevinyhZou, could you help confirm whether these remaining arguments also need to be added? @jinchengchenghh has provided a more comprehensive list, some of which are not necessary now but may become necessary in the future. Perhaps we should also consider adding these.
>
> https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29
As jdk17 is still a experimental feature on flink-1.19: https://nightlies.apache.org/flink/flink-docs-release-1.19/docs/deployment/java_compatibility/#java-17, I think we'd better add these options to avoid the incompatibility on flinkļ¼or we should use jdk11 @PHILO-HE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3237188004
@jinchengchenghh, I just became aware of this. The current Flink CI has already added some Maven arguments (including the proposed args of this PR) that ensure compilation and tests pass on JDK 17. See the link below.
@KevinyhZou, could you help confirm whether these remaining arguments also need to be added? @jinchengchenghh has provided a more comprehensive list, some of which are not necessary now but may become necessary in the future. Perhaps we should also consider adding these.
https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10570][FLINK] Fix UT failure on JDK 17 [incubator-gluten]
Posted by "KevinyhZou (via GitHub)" <gi...@apache.org>.
KevinyhZou commented on PR #10572:
URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3240737840
> nio
The maven options in `flink.yml` seem to have some problems, and the ci errors can be seen here:
https://github.com/apache/incubator-gluten/actions/runs/17365498820/job/49291599404?pr=10248#step:6:1103 @PHILO-HE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org