You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/20 07:43:22 UTC

[GitHub] [flink] yangjunhan commented on a change in pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

yangjunhan commented on a change in pull request #18413:
URL: https://github.com/apache/flink/pull/18413#discussion_r788451618



##########
File path: flink-runtime-web/web-dashboard/src/app/share/customize/job-badge/job-badge.component.spec.ts
##########
@@ -22,10 +22,8 @@ import { JobBadgeComponent } from './job-badge.component';
 
 describe('A job badge', () => {
   it('displays the state', async () => {
-    await render(JobBadgeComponent, {
-      componentProperties: {
-        state: 'RUNNING'
-      }
+    await render(`<flink-job-badge [state]="'RUNNING'"></flink-job-badge>`, {

Review comment:
       I am referring this [changelog](https://github.com/testing-library/angular-testing-library/releases/tag/v11.0.0). 
   
   ![image](https://user-images.githubusercontent.com/50307523/150294733-366026a7-58f8-4967-b4b2-af76a5e77765.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org