You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/11 12:02:54 UTC
[GitHub] [ozone] captainzmc opened a new pull request, #3404: HDDS-6650. S3MultipartUpload support update bucket usedNamespace.
captainzmc opened a new pull request, #3404:
URL: https://github.com/apache/ozone/pull/3404
## What changes were proposed in this pull request?
S3MultipartUpload hasn't support usedNamespace. Currently when we upload key, only usedBytes can be updated.
<img width="351" alt="image" src="https://user-images.githubusercontent.com/13825159/167844815-937d8e82-5480-480d-9f2c-d19bcfcf9bbc.png">
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6650
## How was this patch tested?
Add new test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #3404: HDDS-6650. S3MultipartUpload support update bucket usedNamespace.
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3404:
URL: https://github.com/apache/ozone/pull/3404#issuecomment-1131896825
Thanks @adoroszlai for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3404: HDDS-6650. S3MultipartUpload support update bucket usedNamespace.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3404:
URL: https://github.com/apache/ozone/pull/3404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3404: HDDS-6650. S3MultipartUpload support update bucket usedNamespace.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3404:
URL: https://github.com/apache/ozone/pull/3404#discussion_r872178994
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -229,6 +229,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
trxnLogIndex, ozoneManager.isRatisEnabled());
long numCopy = keyToDelete.getReplicationConfig().getRequiredNodes();
usedBytesDiff -= keyToDelete.getDataSize() * numCopy;
+ } else {
+ checkBucketQuotaInNamespace(omBucketInfo, 1L);
+ omBucketInfo.incrUsedNamespace(1L);
Review Comment:
The update in `omBucketInfo` is lost if this is not an overwrite (or an overwrite with no size diff):
https://github.com/apache/ozone/blob/86ffd947350ede008893283636c86cb1b5d31b38/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java#L240-L241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org