You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2002/10/24 21:38:21 UTC

[5.0] Refactoring Bootstrap and BootstrapService

... as well as the Catalina and CatalinaService classes. The idea is to 
remove the *Service, and have only one set of classes (which would still 
handle all use cases). There has been a number of random method 
additions which make the whole thing a mess (IMO). For example, the 
"Service" version can be made to behave like the non-"Service" one. 
Kinda confusing ...

This will likely break a few things.
Please complain if you like the current mess better ;-)

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [5.0] Refactoring Bootstrap and BootstrapService

Posted by Costin Manolache <cm...@yahoo.com>.
Remy Maucherat wrote:

> Costin Manolache wrote:
> 
>> It was about time !
>>
>> I suppose we'll end up with Bootstrap + Catalina.
>> What I would like is to have a similar bean/ant-like interface
>> on both ( i.e. setter methods for all options configurable on
>> command line + execute() pattern ). With the main distinction
>>  beeing that Bootstrap will be a class with no deps that'll create the
>> loaders and use reflection on Catalina.
> 
> Yes, I figured the bean like methods would be useful, and I plan to have
> some.

IntrospectionUtils has a nice method to process command line arguments and 
call the setters automatically, if called from CLI. It's probably easier 
and keeps things in sync.



>> Please take a look at my latest commit on catalina.xml ( the run/run-wait
>> targets).
>>
>> And I hope the 'random method additions' are not mine :-)
> 
> You're a suspect, I'm afraid. Some had your coding style ;-)

My only defense is that I'm too confused by the 
Bootstrap/BotstrapService/Catalina/CatalinaService, and too old
to change much of the coding style, but I'll try harder :-) 


Costin





--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [5.0] Refactoring Bootstrap and BootstrapService

Posted by Remy Maucherat <re...@apache.org>.
Costin Manolache wrote:

> It was about time !
>
> I suppose we'll end up with Bootstrap + Catalina.
> What I would like is to have a similar bean/ant-like interface
> on both ( i.e. setter methods for all options configurable on
> command line + execute() pattern ). With the main distinction
>  beeing that Bootstrap will be a class with no deps that'll create the
> loaders and use reflection on Catalina.

Yes, I figured the bean like methods would be useful, and I plan to have 
some.

>
> Please take a look at my latest commit on catalina.xml ( the run/run-wait
> targets).
>
> And I hope the 'random method additions' are not mine :-)

You're a suspect, I'm afraid. Some had your coding style ;-)

Remy

>
> Costin
>
> Remy Maucherat wrote:
>
>
> >... as well as the Catalina and CatalinaService classes. The idea is to
> >remove the *Service, and have only one set of classes (which would still
> >handle all use cases). There has been a number of random method
> >additions which make the whole thing a mess (IMO). For example, the
> >"Service" version can be made to behave like the non-"Service" one.
> >Kinda confusing ...
> >
> >This will likely break a few things.
> >Please complain if you like the current mess better ;-)
> >
> >Remy
>
>



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [5.0] Refactoring Bootstrap and BootstrapService

Posted by Costin Manolache <cm...@yahoo.com>.
It was about time !

I suppose we'll end up with Bootstrap + Catalina.
What I would like is to have a similar bean/ant-like interface 
on both ( i.e. setter methods for all options configurable on
command line + execute() pattern ). With the main distinction
 beeing that Bootstrap will be a class with no deps that'll create the 
loaders and use reflection on Catalina.

Please take a look at my latest commit on catalina.xml ( the run/run-wait 
targets). 

And I hope the 'random method additions' are not mine :-)

Costin

Remy Maucherat wrote:

> ... as well as the Catalina and CatalinaService classes. The idea is to
> remove the *Service, and have only one set of classes (which would still
> handle all use cases). There has been a number of random method
> additions which make the whole thing a mess (IMO). For example, the
> "Service" version can be made to behave like the non-"Service" one.
> Kinda confusing ...
> 
> This will likely break a few things.
> Please complain if you like the current mess better ;-)
> 
> Remy

-- 
Costin



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [5.0] Refactoring Bootstrap and BootstrapService

Posted by Endre Stølsvik <En...@Stolsvik.com>.
On Thu, 24 Oct 2002, Remy Maucherat wrote:

| ... as well as the Catalina and CatalinaService classes. The idea is to
| remove the *Service, and have only one set of classes (which would still
| handle all use cases). There has been a number of random method
| additions which make the whole thing a mess (IMO). For example, the
| "Service" version can be made to behave like the non-"Service" one.
| Kinda confusing ...
|
| This will likely break a few things.
| Please complain if you like the current mess better ;-)

I only have the slightest idea what you're talking about, but I guess it
has something with start/stop of catalina?!

If you're still on those files, then make a shutdown-method that actually
_waits_ untill the possibly very length shutdown procedures are done.
Something that hooks onto the process, sends the "shutdown now" signal,
and then _waits_ until catalina replies with "all shutdown procedures
finished", then both processes terminate.

.. or, this might already been implemented. I wouldn't know, I only
remeber that this has annoyed me very much in both 3.2 and 4.0..


-- 
Mvh,
Endre Stølsvik               M[+47 93054050] F[+47 51625182]
Developer @ CoreTrek AS         -  http://www.coretrek.com/
CoreTrek corporate portal / EIP -  http://www.corelets.com/


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>