You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Niclas Hedhman (JIRA)" <ji...@codehaus.org> on 2006/03/08 12:44:23 UTC
[jira] Created: (MPRELEASE-18) Wrong username during
release:prepare tagging
Wrong username during release:prepare tagging
---------------------------------------------
Key: MPRELEASE-18
URL: http://jira.codehaus.org/browse/MPRELEASE-18
Project: maven-release-plugin
Type: Bug
Reporter: Niclas Hedhman
If I my Svn repository requires a different username than the login name, and I issue
mvn -Dmaven.username=niclas@hedhman.org release:prepare
The first phase (checking in modified POMs) will succeed with that username.
Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
WORKAROUND;
Before starting the release:prepare, create a release.properties file manually which contains
maven.username=niclas@hedhman.org
and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Wladimir Kopilevich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104588 ]
Wladimir Kopilevich commented on MRELEASE-83:
---------------------------------------------
I had the same problem and found out, that during cvs checkin the class org.apache.maven.scm.provider.cvslib.cvsjava.util.CvsConnection loads the CVSROOT from "CVS\Root" relative to the local working directory. The file gets created by the initial cvs checkout of the project.
In my case i checked out the project "abc" initially with user "a" so abc\CVS\Root contained something like ":pserver:a@server:...." but i had user b configured in <connection/>. The first check of modified files by release:prepare is made with user "b" but the check-in uses "a".
Do anybody know whether this behaviour is intended and why?
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-7
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse updated MRELEASE-83:
-------------------------------------
Component/s: scm
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=130588#action_130588 ]
Dennis Lundberg commented on MRELEASE-83:
-----------------------------------------
Another workaround is to specify your remote username in a <server> section in settings.xml.
I have something like this in mine:
{code:xml}
<settings>
<servers>
...
<server>
<username>dennisl</username>
<id>apache.releases</id>
...
</server>
...
</servers>
...
</settings>
{code}
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-8
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MRELEASE-83:
------------------------------
Fix Version/s: (was: 2.0-beta-7)
2.0-beta-8
we need to push a release of beta-7 to do a release of 2.0.8. Bumping to next release
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-8
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MRELEASE-83:
------------------------------------
Fix Version/s: (was: 2.0)
Moving to a later version.
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MRELEASE-83:
---------------------------------
Patch Submitted: [Yes]
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Attachments: AbstractCvsCheckInCommand.java.patch
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse updated MRELEASE-83:
-------------------------------------
Fix Version/s: 2.0-beta-7
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-7
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MRELEASE-83:
---------------------------------
Fix Version/s: (was: 2.0-beta-9)
2.0-beta-10
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-10
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=235322#action_235322 ]
Brett Porter commented on MRELEASE-83:
--------------------------------------
this needs a closer review, since the original reporter had issues with SVN, and the patch only covers CVS. It also indicates there's an SCM component to be fixed, which isn't in scope for the next release plugin release now that 1.4 is already out.
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Attachments: AbstractCvsCheckInCommand.java.patch
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=all ]
Brett Porter updated MRELEASE-83:
---------------------------------
Fix Version: (was: 2.0-beta-4)
2.0
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Type: Bug
> Reporter: Niclas Hedhman
> Fix For: 2.0
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MRELEASE-83:
---------------------------------
Fix Version/s: (was: 2.0-beta-8)
2.0-beta-9
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-9
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Torben Giesselmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=129949#action_129949 ]
Torben Giesselmann commented on MRELEASE-83:
--------------------------------------------
Same problem with 2.0-beta-8 and SVN.
I looked into {{DefaultScmRepositoryConfigurator}}: the username is contained in the _host_ part of the {{ScmProviderRepositoryWithHost}}, but it's never extracted from that and {{scmRepo.setUser( username )}} is never called with that value.
So I changed that and wrote some code to extract the username and password from the SVN URL. Now the username is set. Therefore, in {{ScmCommitPhase.checkin(...)}} the following code is called
{{result = provider.checkIn( repository, fileSet, (ScmVersion) null, message );}}
with a configured username:
- in the provider's username attribute
- the URL
- and the host name
but _still_ I'm being asked for the wrong username! What is going on after that? I mean: it's a direct call on the {{ScmProvider}}. A problem with the SVN provider implementation?!?
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-8
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Mike Dillon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=188720#action_188720 ]
Mike Dillon commented on MRELEASE-83:
-------------------------------------
Does the fix for MRELEASE-442 solve this?
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-10
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=all ]
Brett Porter updated MRELEASE-83:
---------------------------------
Fix Version: 2.0-beta-4
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Type: Bug
> Reporter: Niclas Hedhman
> Fix For: 2.0-beta-4
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-83) Wrong username during release:prepare
tagging
Posted by "Raphael Ackermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raphael Ackermann updated MRELEASE-83:
--------------------------------------
Attachment: AbstractCvsCheckInCommand.java.patch
The attached patch fixes this issue for me when using CVS (the all java cvs client)
I get the same result that the first Login and also the update cvs commands work, but the checkin and tag commands won't work. As others have commented before, it uses the username defined in the CVS/Root file. Debugging the code I found out that it always checks the CVS/Root file, but if there is a -d option that takes precedence.
-d cvs_root_directory
Use cvs_root_directory as the root directory pathname of the reposi-
tory. Overrides the setting of the $CVSROOT environment variable.
See `Repository' in the CVS manual.
A change in revision 518698 changed the behaviour to not include the -d option when generating the tag, checkin, update and branch cvs commands. The comment for that revision indicates that this was a problem for the update command. I think that maybe it should have only be changed for the update command while leaving the tag and checkin behaviour to include the -d option.
See the comment for rev 518698 below:
Revision: 518698
Author: evenisse
Date: 3/15/07 6:17 PM
Comment:
Remove cvsroot from the command when it isn't needed. It fix some pb with update when files are updated only on the root directory and not detected.
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
> Attachments: AbstractCvsCheckInCommand.java.patch
>
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-83) Wrong username during
release:prepare tagging
Posted by "Jaran Nilsen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100668 ]
Jaran Nilsen commented on MRELEASE-83:
--------------------------------------
Having the same issue with 2.0-beta-6. The first checkout the plugin performs works fine, but when the modified POM is to be checked in, the plugin uses the username of the logged on user on the computer, instead of what's specified in the scm.connection/developerConnection in the POM. The -Dusername= parameter, or the workaround proposed by Niclas is not working in 2.0-beta-6 as far as I can see.
> Wrong username during release:prepare tagging
> ---------------------------------------------
>
> Key: MRELEASE-83
> URL: http://jira.codehaus.org/browse/MRELEASE-83
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: scm
> Reporter: Niclas Hedhman
>
> If I my Svn repository requires a different username than the login name, and I issue
> mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
> maven.username=niclas@hedhman.org
> and everything will work.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira