[GitHub] [zookeeper] hanm commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master

[GitBox <gi...@apache.org>]

hanm commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r300187273
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -968,6 +984,7 @@ protected long queueCommittedProposals(Iterator<Proposal> itr,
     public void shutdown() {
         // Send the packet of death
         try {
+            queuedPackets.clear();
 
 Review comment:
   This seems unrelated to this patch, but it looks the right thing to do. Just want to make sure this was not accidentally introduced.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services