You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Jonathan Sobel (JIRA)" <ji...@apache.org> on 2009/02/13 21:25:01 UTC

[jira] Created: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

InsertPage plugin carries dashes from section breaks into output
----------------------------------------------------------------

                 Key: JSPWIKI-503
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
             Project: JSPWiki
          Issue Type: Bug
          Components: Plugins
    Affects Versions: 2.8
            Reporter: Jonathan Sobel
            Priority: Minor


When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.

Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.

The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JSPWIKI-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673611#action_12673611 ] 

Janne Jalkanen commented on JSPWIKI-503:
----------------------------------------

Yup, I think this is a bug.  However, the patch will fail with 8 or more consecutive dashes.  I think it should just eat *all* the dashes and not stop at eight.

I think this is valid for 2.8.2.

> InsertPage plugin carries dashes from section breaks into output
> ----------------------------------------------------------------
>
>                 Key: JSPWIKI-503
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>            Reporter: Jonathan Sobel
>            Priority: Minor
>             Fix For: 2.8.2, 3.0
>
>         Attachments: JSPWiki-503.patch
>
>
> When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.
> Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.
> The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske closed JSPWIKI-503.
--------------------------------

    Resolution: Fixed
      Assignee: Harry Metske

Fixed in 2.8.2-svn-13 and 3.0.0-svn-70

> InsertPage plugin carries dashes from section breaks into output
> ----------------------------------------------------------------
>
>                 Key: JSPWIKI-503
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>            Reporter: Jonathan Sobel
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 2.8.2, 3.0
>
>         Attachments: JSPWiki-503.patch
>
>
> When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.
> Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.
> The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Janne Jalkanen updated JSPWIKI-503:
-----------------------------------

    Fix Version/s: 3.0

OOps, and 3.0.  Need to fix both before this can be closed.

> InsertPage plugin carries dashes from section breaks into output
> ----------------------------------------------------------------
>
>                 Key: JSPWIKI-503
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>            Reporter: Jonathan Sobel
>            Priority: Minor
>             Fix For: 2.8.2, 3.0
>
>         Attachments: JSPWiki-503.patch
>
>
> When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.
> Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.
> The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske updated JSPWIKI-503:
---------------------------------

    Attachment: JSPWiki-503.patch

Well, the documentation (http://www.jspwiki.org/wiki/TextFormattingRules) indeed says:
??----       = make a horizontal ruler. Extra '-' is ignored.??

We could "eat"  the additional dashes with the attached patch, would that be the correct approach ?

> InsertPage plugin carries dashes from section breaks into output
> ----------------------------------------------------------------
>
>                 Key: JSPWIKI-503
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>            Reporter: Jonathan Sobel
>            Priority: Minor
>         Attachments: JSPWiki-503.patch
>
>
> When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.
> Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.
> The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JSPWIKI-503) InsertPage plugin carries dashes from section breaks into output

Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Janne Jalkanen updated JSPWIKI-503:
-----------------------------------

    Fix Version/s: 2.8.2

Marked for 2.8.2.

> InsertPage plugin carries dashes from section breaks into output
> ----------------------------------------------------------------
>
>                 Key: JSPWIKI-503
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-503
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>            Reporter: Jonathan Sobel
>            Priority: Minor
>             Fix For: 2.8.2, 3.0
>
>         Attachments: JSPWiki-503.patch
>
>
> When using the "section" parameter to the InsertPage plugin, the sections are delimited with horizontal rule lines.  In the wiki markup source, the minimal number of hyphens to create a rule line is 4, I believe, but it is OK to use more hyphens.  Any number greater than or equal to 4 creates the HR line.
> Unfortunately, the InsertPage plugin with the "section" parameter eats EXACTLY 4 hyphens and copies the rest into the output, leaving meaningless marks in the visible wiki page.
> The only workaround is to go through your source pages and make sure your users typed EXACTLY 4 hyphens where they wanted section breaks.  Not pleasant.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.