You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Karl-Heinz Marbaise (JIRA)" <ji...@codehaus.org> on 2014/06/14 23:38:10 UTC

[jira] (MEAR-182) Skinny WAR's - Skip Class-Path Modification in Manifest

    [ https://jira.codehaus.org/browse/MEAR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=348040#comment-348040 ] 

Karl-Heinz Marbaise commented on MEAR-182:
------------------------------------------

After taking a look into that i would suggest to make an supplemental option like {{skipClassPathModification}} which is set to false by default cause otherwise this would change the default behaviour of the plugin which is not a good way. If set to true it could do exactly what you suggested. 

> Skinny WAR's - Skip Class-Path Modification in Manifest
> -------------------------------------------------------
>
>                 Key: MEAR-182
>                 URL: https://jira.codehaus.org/browse/MEAR-182
>             Project: Maven Ear Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Mario Däpp
>         Attachments: MEAR-182-patch.txt
>
>
> From Java EE 5, a library directory may be specified in the application.xml (element library-directory). The Maven EAR Plugin already supports this for generating the application.xml (value of property defaultLibBundleDir).
> The Java EE 5 specification mandates that all JAR files contained in the library directory be made available to all modules within the EAR file (cf. chapter EE.8.2.1 Bundled Libraries, section 2).
> If one specifies both the skinnyWars (value = true) and defaultLibBundleDir parameters, the libraries will be removed from the WAR and copied to the defaultLibBundleDir. They will also be added to the Class-Path in the WAR files manifest. This is unnecessary as per the Java EE 5 specification. Even worse, it breaks my EAR on WebLogic (classloading issues).
> I therefore propose the following improvement to the skinny WAR's functionality: If the Java EE version is 5 or greater and the defaultLibBundleDir has been specified, the Class-Path in the WAR's manifest should remain unchanged.
> I've created a corresponding patch and integration test.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)